Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on yarn run storybook #369

Closed
SeanSilke opened this issue Jul 6, 2018 · 10 comments
Closed

Error on yarn run storybook #369

SeanSilke opened this issue Jul 6, 2018 · 10 comments

Comments

@SeanSilke
Copy link

yarn run storybook leads to error TypeError: plugins.extractText is not a function
and storybook did not start.

@silvenon
Copy link
Collaborator

silvenon commented Jul 7, 2018

What is your version of Node? I'm getting errors for JSX and class properties, which also prevents the stories from rendering, but I'm curious about where your error is coming from.

@SeanSilke
Copy link
Author

@silvenon node version is v8.11.3

@MannyC
Copy link

MannyC commented Jul 11, 2018

Yeah, storybook isn't working at all for me.

I did some investigation but ended up giving up. Basically, the react-transition-group storybook isn't compatible with webpack 4, but the project itself has been bumped to use 4.

plugins.extractText seems to have been removed form webpack-atoms, probably because it wasn't compatable with webpack 4 ( see here ). You can alter RTG to use extract-text-webpack-plugin directly, although they actually recommend using mini-css-extract-plugin instead for webpack 4 so I tried that. That errored out for me, and because I don't know where all this is sitting within the overall project, I just left it.

edit:

~$ node --version
v10.6.0

@silvenon
Copy link
Collaborator

silvenon commented Jul 15, 2018

@jquense do you use Storybook when developing react-transition-group? I stopped using it a long time ago in general because I find it to be too much of a hassle, I just use yarn link instead. But I can try to revive Storybook if you think it's a good idea to keep it. Otherwise we could delete it.

@jquense
Copy link
Collaborator

jquense commented Jul 15, 2018

I use use it just to verify stuff when i do local dev yeah. Its really not important tho to fix, or rather i should fix it since i'm the one that uses it. I don't want to remove it tho since it's got some useful examples of use that may be broadly interesting

@pajtai
Copy link

pajtai commented Aug 23, 2018

Is there an alternative way to look at demos? I couldn't get it to run either.

@pajtai
Copy link

pajtai commented Aug 23, 2018

To answer my own question and to others for reference, the docs have codebox examples.

So each of the following pages lets you see the transitions and play with them:

  1. http://reactcommunity.org/react-transition-group/transition/
  2. http://reactcommunity.org/react-transition-group/css-transition/
  3. http://reactcommunity.org/react-transition-group/transition-group/

@cabinhero
Copy link

OK, I found a method to walk around the error, That's just remove the code like this.
image

@emwalker
Copy link

emwalker commented Oct 4, 2018

If the storybook is broken and a "wontfix," perhaps a documentation update to remove the reference to the storybook?

JoeWroe added a commit to JoeWroe/react-transition-group that referenced this issue Dec 15, 2018
∆ Ran into issue reactjs#369 (Error on `yarn run storybook`) when trying out the
library, ended up there because the docs where slightly out of date. Just a
quick few lines to ensure they're more current.
@silvenon
Copy link
Collaborator

Works now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants