Skip to content

Commit

Permalink
Merge pull request #116 from alonbt/master
Browse files Browse the repository at this point in the history
docs(migration): fix key value + adding close tag for CSSTransition when needed
  • Loading branch information
taion authored Jul 16, 2017
2 parents 91f9b86 + 8968fd6 commit 20b16c6
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class TodoList extends React.Component {

render() {
const items = this.state.items.map((item, i) => (
<div key={item} onClick={() => this.handleRemove(i)}>
<div key={i} onClick={() => this.handleRemove(i)}>
{item}
</div>
));
Expand All @@ -88,7 +88,7 @@ The most straightforward way to migrate is to use `<TransitionGroup>` instead of
```diff
render() {
const items = this.state.items.map((item, i) => (
<div key={item} onClick={() => this.handleRemove(i)}>
<div key={i} onClick={() => this.handleRemove(i)}>
{item}
</div>
));
Expand Down Expand Up @@ -141,14 +141,14 @@ Now we add the `<CSSTransition>` component:
render() {
const items = this.state.items.map((item, i) => (
+ <CSSTransition
+ key={item}
+ key={i}
+ classNames="example"
+ timeout={{ enter: 500, exit: 300 }}
+ >
<div onClick={() => this.handleRemove(i)}>
{item}
</div>
+ <CSSTransition>
+ </CSSTransition>
));

return (
Expand Down Expand Up @@ -184,15 +184,15 @@ We can then use it like:
render() {
const items = this.state.items.map((item, i) => (
- <CSSTransition
- key={item}
- key={i}
- classNames="example"
- timeout={{ enter: 500, exit: 300 }}
- >
+ <FadeTransition>
<div onClick={() => this.handleRemove(i)}>
{item}
</div>
- <CSSTransition>
- </CSSTransition>
+ </FadeTransition>
));

Expand Down

0 comments on commit 20b16c6

Please sign in to comment.