Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchors without an href but with a tabIndex should require a role of button #45

Closed
kloots opened this issue Jun 4, 2015 · 0 comments · Fixed by #47
Closed

Anchors without an href but with a tabIndex should require a role of button #45

kloots opened this issue Jun 4, 2015 · 0 comments · Fixed by #47

Comments

@kloots
Copy link
Collaborator

kloots commented Jun 4, 2015

Currently we only require the ARIA button role on anchors whose href is set to "#". We should also require it for anchors with a tabIndex but without an href.
kloots pushed a commit that referenced this issue Jun 4, 2015
[fixed] Issue where label assertion returns a false negative when lab…
4755a24 
…el is inside a child Component (fixes #44)

[added] Tests to ensure anchors with a tabIndex but without an href require an ARIA button role (fixes #45)
[added] selection and option to the list of interactive elements that require labels
[removed] getFailures() method since all failures are now logged asynchronously
@kloots kloots mentioned this issue Jun 4, 2015
Closed
kloots pushed a commit that referenced this issue Jun 8, 2015
[fixed] Issue where label assertion returns a false negative when lab…
c4d52fc 
…el is inside a child Component (fixes #44)

[added] Tests to ensure anchors with a tabIndex but without an href require an ARIA button role (fixes #45)
[added] selection and option to the list of interactive elements that require labels
[removed] getFailures() method since all failures are now logged asynchronously
@kloots kloots mentioned this issue Jun 8, 2015
Merged
angus-c added a commit that referenced this issue Jun 8, 2015
@angus-c
Merge pull request #47 from rackt/label-assertion-update
0dd51c3 
Fixes for issue #44 and #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for issue #44 and #45 reactjs/react-a11y
Fixes for issues #44 and #45 reactjs/react-a11y
1 participant
@kloots