Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Babel, JSX, and Build Steps #33

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Conversation

lazu-ardi
Copy link
Contributor

@lazu-ardi lazu-ardi commented Feb 18, 2019

Hey guys im done translating the page please review it

@netlify
Copy link

netlify bot commented Feb 18, 2019

Deploy preview for idreactjs ready!

Built with commit 1aa81f1

https://deploy-preview-33--idreactjs.netlify.com

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DMM31 Thank you for the contribution, so sorry I had a busy week and wasn't able to review. There's several things that I need your opinion about the better translation for some terms but after that from me it's LGTM 🎉

content/docs/faq-build.md Outdated Show resolved Hide resolved
content/docs/faq-build.md Outdated Show resolved Hide resolved
content/docs/faq-build.md Outdated Show resolved Hide resolved
content/docs/faq-build.md Outdated Show resolved Hide resolved
content/docs/faq-build.md Outdated Show resolved Hide resolved
@regalius
Copy link
Member

regalius commented Mar 3, 2019

Hi @DMM31 , any update regarding this PR? 😄

@netlify
Copy link

netlify bot commented Mar 25, 2019

Deploy preview for id-reactjs ready!

Built with commit 3b1a9c7

https://deploy-preview-33--id-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 25, 2019

Deploy preview for id-reactjs ready!

Built with commit 1aa81f1

https://deploy-preview-33--id-reactjs.netlify.com

@grikomsn grikomsn requested review from grikomsn and resir014 and removed request for gedeagas and arfianadam July 7, 2019 19:28
@grikomsn grikomsn self-assigned this Jul 7, 2019
@grikomsn grikomsn requested a review from regalius July 7, 2019 19:29
@grikomsn grikomsn changed the title Translated Babel, JSX, and Build Steps Translate Babel, JSX, and Build Steps Jul 7, 2019
@resir014 resir014 merged commit e25d556 into reactjs:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants