-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Test Utilities Page #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to this discussion once it is added to glossary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like just need to adjust several common terms and we're good to go 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 last thing mas @Lukereonal , please translate strings inside code blocks to make it uniform across pages and I think, we're good to go 👍
@regalius sorry i missed that, I already translate the string 🙏🏻 |
Sorry, noticed another thing mas @Lukereonal , capitalized
Because in the case of no. 2 |
@regalius Thanks for the input, I already change some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM from me @Lukereonal ! Thank you so much for the hardwork 🎉
@gedeagas @arfianadam any comments before we're merging this PR?
@arfianadam Thanks for the review, I already fix it please let me know if there anything else 🙏🏻 |
Deploy preview for idreactjs ready! Built with commit 8533b7a |
This PR looks like it's ready to be merged what do you think guys? @gedeagas @arfianadam |
Deploy preview for id-reactjs ready! Built with commit 8533b7a |
It got LGTM from @arfianadam & @gedeagas, and merged. Thanks for the contribution mas @Lukereonal ! 🎉 |
Mohon reviewnya guys 🙏🏻