Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate JavaScript Environment Requirements #15

Merged
merged 6 commits into from
Feb 12, 2019
Merged

Translate JavaScript Environment Requirements #15

merged 6 commits into from
Feb 12, 2019

Conversation

antonybudianto
Copy link
Contributor

Mohon reviewnya kakak2 sekalian 🙏

@antonybudianto antonybudianto changed the title Update reference-javascript-environment-requirements.md Translate JavaScript Environment Requirements Feb 11, 2019
@mazipan
Copy link
Collaborator

mazipan commented Feb 11, 2019

Refer to: #2

@mazipan
Copy link
Collaborator

mazipan commented Feb 11, 2019

Sepertinya udah okey semua sih ini kata-katanya kalau dari saya.

@tesseralis tesseralis mentioned this pull request Feb 11, 2019
Closed
96 tasks
regalius
regalius requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just need to adjust common terms and italicize several loanwords and we're good to go mas @antonybudianto 🎉

content/docs/reference-javascript-environment-requirements.md Outdated Show resolved Hide resolved
regalius
regalius approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge this @arfianadam @gedeagas ?

gedeagas
gedeagas approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@gedeagas gedeagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me @regalius

@gedeagas gedeagas merged commit 7456bf1 into reactjs:master Feb 12, 2019
@antonybudianto
Copy link
Contributor Author

Thanks guys 🎉

@antonybudianto antonybudianto deleted the patch-1 branch February 12, 2019 09:59
@arfianadam arfianadam removed their request for review February 12, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arfianadam arfianadam arfianadam left review comments

@gedeagas gedeagas gedeagas approved these changes

@mazipan mazipan mazipan approved these changes

@regalius regalius regalius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antonybudianto @mazipan @regalius @gedeagas @arfianadam