Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate DOM Elements #120

Merged
merged 7 commits into from
Nov 13, 2019
Merged

Conversation

kfnx
Copy link
Contributor

@kfnx kfnx commented Oct 20, 2019

Mohon reviewnya semua, sedikit catatan: saya kurang yakin apakah style dan children perlu diterjemahkan ? di PR ini tidak saya terjemahkan, hanya diberi italic.

@netlify
Copy link

netlify bot commented Oct 20, 2019

Deploy preview for idreactjs ready!

Built with commit c5e3dd3

https://deploy-preview-120--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Oct 20, 2019

Deploy preview for id-reactjs ready!

Built with commit c5e3dd3

https://deploy-preview-120--id-reactjs.netlify.com

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada beberapa isu typo dan penerjemahan yang perlu dibetulkan sebelum di-merge ya.

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@kfnx
Copy link
Contributor Author

kfnx commented Oct 24, 2019

thanks for the feedback guys @resir014 @paramithatm, i have done the changes

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@kfnx
Copy link
Contributor Author

kfnx commented Oct 24, 2019

thanks feedbacknya @vferdiansyah, sudah saya update ya.

Copy link
Contributor

@vferdiansyah vferdiansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these new changes, LGTM!

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@vferdiansyah
Copy link
Contributor

shouldn't this be merged already @resir014?

@resir014
Copy link
Member

@vferdiansyah Sure, I'll take a quick look first.

@resir014 resir014 changed the title Reference dom elements Translate DOM Elements Nov 13, 2019
@resir014 resir014 merged commit 4e10ffb into reactjs:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants