chore: rename tests add derived interface test

[TimothyMakkison]

• Renamed DerivedRefitInterfaceTest and DerivedNonRefitInterfaceTest
• Added InterfaceDerivedFromRefitBaseTest

[TimothyMakkison]

@ChrisPulman did you have any thoughts regarding my comment? The lack of incremental generator tests are the main blocker preventing me from adding incremental generation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (6ebeda5) to head (8f41deb).
Report is 91 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
- Coverage   87.73%   83.74%   -3.99%     
==========================================
  Files          33       36       +3     
  Lines        2348     2449     +101     
  Branches      294      345      +51     
==========================================
- Hits         2060     2051       -9     
- Misses        208      316     +108     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChrisPulman]

@ChrisPulman did you have any thoughts regarding my comment? The lack of incremental generator tests are the main blocker preventing me from adding incremental generation.

Could we go with Add a new InterfaceStubGenerator.Roslyn41 option for the time being, this way we can maintain older versions as they currently exist and open a path to pure incremental generators, we can drop the relevant support if required once we get a stable version of 41.

[ChrisPulman]

Roslyn 38, 40 and 41 are all supported by Rider, VS2019 (Fully updated) and VS2022, so really using Roslyn 41 shouldn't be an issue.

[ChrisPulman]

I am happy with updating the version of Rosyln to a single newer version rather than trying to support 2 or 3 versions, this would involve changing the project setup to have a single NetStandard project instead of a shared project.
Would you be okay with going down that route?
While understanding that we will drop support for some versions of Visual Studio we can advance Refit to be what people are calling for. So, while keeping a version as low as possible i.e. Roslyn 41, I am happy with anything up to Roslyn 46 if that makes anything easier.

[TimothyMakkison]

Would you be okay with going down that route?

I'm happy with either route. My current solution was to update Roslyn 4.0 to Roslyn 4.1, this way we keep support for 3.9.

we will drop support for some versions of Visual Studio we can advance Refit to be what people are calling for.

Personally, none of my planned changes require dropping support for anything. I only need 4.1 to use WithTrackingName to determine if the generator is caching correctly. This would be an extremely minimal change regardless of which approach is taken.

I am happy with anything up to Roslyn 46 if that makes anything easier.

This should be a separate issue but I did wonder if ForAttributeWithMetadataName could be used to look for interfaces containing the Refit Http attributes.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.