Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Add Net 8.0 #296

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Feature : Add Net 8.0 #296

merged 1 commit into from
Jan 1, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature

What is the current behavior?

No Net 8.0 target exists.

What is the new behavior?

Net 8.0 Added.

What might this PR break?

Non Expected

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (63a8b3c) 74.59% compared to head (388c2dc) 62.62%.

Files Patch % Lines
src/Punchclock/PriorityQueue.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #296       +/-   ##
===========================================
- Coverage   74.59%   62.62%   -11.98%     
===========================================
  Files           6        6               
  Lines         437      297      -140     
  Branches       51       52        +1     
===========================================
- Hits          326      186      -140     
  Misses         97       97               
  Partials       14       14               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson merged commit 4a0d181 into main Jan 1, 2024
1 of 3 checks passed
@glennawatson glennawatson deleted the CP_AddNet8_0 branch January 1, 2024 00:34
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants