Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Add Attribute Passthrough #12

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Feature

What is the current behavior?

ReactiveCommands are generated without the ability to add Property Attributes

What is the new behavior?

ReactiveCommands are generated with the ability to add Property Attributes using
[ReactiveCommand]
[property: AttributeName]

Analyzer added to allow property attributes to be placed on a Method.

What might this PR break?

N/A new feature.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson merged commit 0942a8c into main Jul 31, 2024
1 check passed
@glennawatson glennawatson deleted the CP_FeatureAddAttributePassthroughToCommand branch July 31, 2024 00:01
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants