Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add maui and use HttpClient #788

Merged
merged 8 commits into from
Jun 25, 2022
Merged

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Jun 25, 2022

Add the Maui targets, such as net6-android/ios/mac etc
Change the WebRequest over to using HttpClient. WebRequest has been deprecated. This includes now the ability to specify the type of fetch operation to retrieve.
Minor cleanups throughout the code.

@glennawatson glennawatson enabled auto-merge (squash) June 25, 2022 06:42
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #788 (d08ea78) into main (d5f85dc) will increase coverage by 0.17%.
The diff coverage is 34.78%.

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   57.97%   58.15%   +0.17%     
==========================================
  Files          58       59       +1     
  Lines        3367     3348      -19     
==========================================
- Hits         1952     1947       -5     
+ Misses       1415     1401      -14     
Impacted Files Coverage Δ
src/Akavache.Core/DependencyResolverMixin.cs 92.00% <0.00%> (ø)
src/Akavache.Core/HttpMixinExtensions.cs 55.55% <0.00%> (-44.45%) ⬇️
src/Akavache.Core/Json/JsonSerializationMixin.cs 54.54% <0.00%> (ø)
src/Akavache.Drawing/BitmapImageMixin.cs 0.00% <0.00%> (ø)
src/Akavache.Sqlite3/Registrations.cs 83.33% <0.00%> (ø)
src/Akavache/LinkerPreserve.cs 0.00% <0.00%> (ø)
...kavache.Core/Platforms/shared/AkavacheHttpMixin.cs 36.00% <34.54%> (+1.34%) ⬆️
...atforms/shared/DefaultAkavacheHttpClientFactory.cs 100.00% <100.00%> (ø)
...rc/Akavache.Core/Platforms/shared/Registrations.cs 93.33% <100.00%> (+0.47%) ⬆️
src/Akavache.Sqlite3/SQLite.cs 35.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f85dc...d08ea78. Read the comment docs.

[SuppressMessage("Design", "CA1065: Properties should not fire exceptions.", Justification = "Extreme non standard case.")]
public static string ApplicationName
{
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these merge issues, or is GitHub UI bugged?

@glennawatson glennawatson merged commit da43863 into main Jun 25, 2022
@glennawatson glennawatson deleted the glennawatson/add/httpclient branch June 25, 2022 15:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants