Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new logo image #586

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Use the new logo image #586

merged 2 commits into from
Jun 18, 2020

Conversation

worldbeater
Copy link
Contributor

What kind of change does this PR introduce?

Akavache logo is updated with the new image from the styleguide repository.

Planning to update Directory.Build.props to use the new image as well soon.

What might this PR break?

Nothing.

@worldbeater
Copy link
Contributor Author

worldbeater commented Jun 18, 2020

Wondering if there is a way to somehow replace the image at https://avatars0.githubusercontent.com/u/5924219?v=3&s=200 with this one https://raw.githubusercontent.com/reactiveui/styleguide/master/logo_akavache/main.png so published Akavache NuGet packages could use the new image.

Update
It appears we are using the image from the Akavache GitHub organization.
Probably replacing the avatar there would be sufficient.

@worldbeater worldbeater marked this pull request as ready for review June 18, 2020 17:42
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #586 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   50.82%   50.82%           
=======================================
  Files          56       56           
  Lines        3343     3343           
  Branches      551      551           
=======================================
  Hits         1699     1699           
  Misses       1459     1459           
  Partials      185      185           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b11e15c...2c461ad. Read the comment docs.

@glennawatson glennawatson merged commit 9c1b132 into master Jun 18, 2020
@glennawatson glennawatson deleted the newer-logo branch June 18, 2020 18:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants