-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ChangeSetMergeTracker so that it correctly works with Value Types #940
Fix for ChangeSetMergeTracker so that it correctly works with Value Types #940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump, for rebase and review, feedback above seems to have been addressed
Sorry I was on vacation the past 10 days. It will now just use the given comparer or EqualityComparer.Default (if not provided). |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
ReferenceEquals
breaks value types #931 by fixingChangeSetMergeTracker
(the basis for multiple operators includingMergeManyChangeSets
,MergeChangeSets
, andTransformManyAsync
)ReferenceEquals
withEqualityComparer<T>.Default.Equals
ReferenceEquals
is explicitly needed (which will gracefully handle value types)Other Fixes
ToObservableOptional
with a more efficient implementation that does not useReferenceEquals