Feature: Use Flag instead of Counter for TransformManyAsync/TransformOnObservable #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made the Stress Tests fail worse
- Change to use Flag instead of counter - Rollback other changes to use a counter instead of a flag - Use SubscribeSafe in more places
…ullop/DynamicData into feature/more-update-counters
dwcullop
changed the title
…in TransformOnObservable and TransformManyAsync.
JakenVeina
approved these changes
Feb 5, 2024
RolandPheasant
approved these changes
Feb 5, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a counter, it is possible to get into a state where no child changesets are emitted because a rapid number of constant changes will prevent the counter from reaching zero. Instead of a counter, it will now use a flag so that only changes initiated by parental changes are merged together (per the original intention).
Bonus Changes
OnErrorare supported)