[BUG] SortedObservableCollectionAdaptor does Remove -> Add instead of Replace when index not changed #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 16:48
Change-Id: Ib7564fb941849b4a12b30d3b6bc4dd6ab8dabfc8
Change-Id: Ib62b5916b63961e2b87b48f8d398ab37905d8497
|
|
glennawatson
approved these changes
Aug 21, 2020
|
@radupetrisel you'll need to sign the CLA before I can merge this one. |
|
Signed 😄 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
#391
What is the new behavior?
SortedObservableCollectionAdaptor.DoUpdate uses Replace if the updated item's index does not change from the update.
The behavior stays the same if the index is changed.
What might this PR break?
Uses that rely on #391
Please check if the PR fulfills these requirements
not neededDocs have been added / updated (for bug fixes / features)