-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reactpy.run
and configure(...)
refactoring
#1051
reactpy.run
and configure(...)
refactoring
#1051
Conversation
reactpy.run
failuresreactpy.run
refactoring
@rmorshea |
I was planning on doing a 1.0.1 release tomorrow. Should this wait for the next release? |
Yes, technically this release has an API change ( |
I discovered that our I attempted to rewrite |
reactpy.run
refactoringreactpy.run
and configure(...)
refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally just minor things to correct.
@rmorshea This seems to be mergeable, but needs approval. |
Issues
Right now
reactpy.run
can fail in fairly unpredictable ways which give little in terms of stack traces.Summary
This refactors the
reactpy.run
call stack in order allow failures that are user-readable.reactpy.backends.utils.find_all_implementations()
to first try to import<backend_name>
before importingreactpy.backend.<backend_name>
reactpy.run
to silently failuvicorn
directly withinserve_with_uvicorn
in order to defer import.ModuleNotFound: Could not import uvicorn
exception to tell the user what went wrongCommonOptions.serve_index_route: bool
allow_reuse_waiting_ports
parameter onfind_available_port()
BackendImplementation
toBackendProtocol
SUPPORTED_PACKAGES
so thatFastAPI
has a chance to run beforestarlette
SUPPORTED_PACKAGES
toSUPPORTED_BACKENDS
reactpy.backend.*
code to be more human readableif
statements where possiblecontextlib.supress
where possiblerequirements.txt
fileChecklist
changelog.rst
has been updated with any significant changes.