Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Issue
accounts were only getting added to one group when creating an account, instead of being added to all groups they should have been added to. i.e. the initial user should be added to the
accounts-manager
andsystem-manager
groups when created, but was only being added toaccounts-manager
and therefore no shop could be created.Solution
Update the
addAccountToGroup
function to run synchronously as to not overwrite the other data being run at the same time.Breaking changes
None
Testing
accounts.groups
array has both groups.