Warn about non-unique names of functionsByType functions #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5464
Impact: minor
Type: refactor
Issue
Logging and stack traces are confusing when all functions of a particular type have the same name, as has been the pattern. For example, all plugins that register a "startup" function also name that function "startup".
Solution
#5464 suggested making unique names mandatory but I'm only logging a warning on startup. I've updated all built-in services and plugins so that all function names are unique and the warning does not print on startup.
Breaking changes
None
Testing
Verify no warnings about
functionsByTypename are shown in the API startup logs. Temporarily change one fn name to be the same as another of that type, and verify that the warning now shows in the logs.