Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use Factory to mock FulfillmentMethod #5988

Conversation

trojanh
Copy link
Contributor

@trojanh trojanh commented Dec 21, 2019

Signed-off-by: trojanh [email protected]

Resolves N.A.
Impact: minor
Type: refactor

Issue

Use FulfillmentMethod factory to mock FulfillmentMethod schema data.

@willopez
Copy link
Member

@trojanh this looks good, other than the conflict, please resolve. Thanks!

@willopez willopez self-requested a review December 26, 2019 18:45
… into use-factory-for-shipment-methods

Signed-off-by: trojanh <[email protected]>
@trojanh
Copy link
Contributor Author

trojanh commented Dec 26, 2019

resolved the conflicts @willopez , thanks 👍

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @trojanh!

@willopez willopez merged commit f5d6050 into reactioncommerce:release-3.0.0 Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants