-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor 3.0 fixes #5977
Merged
Merged
Some minor 3.0 fixes #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #5796 Signed-off-by: Eric Dobbertin <[email protected]>
Fixes #4961 Signed-off-by: Eric Dobbertin <[email protected]>
resolves #4813 Signed-off-by: Eric Dobbertin <[email protected]>
Resolves #4813 Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
willopez
approved these changes
Dec 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4961
Resolves #5796
Resolves #4813
Impact: minor
Type: feature|bugfix
Issues
approveOrderPayments
mutation could not be called internally by plugins syncing from another systemShop
resolvers for fields that return connections did not work (see Graphql requests which return Shop fail if requesting any of these fields: administrators, groups, roles, and tags. #4961)catalogItemProduct
GraphQL query did not accept ashopId
for disambiguation.defaultParcelSize
fields were required but they shouldn't beSolution
approveOrderPayments
supportsisInternalCall
Shop
resolvers for fields that return connections work properlycatalogItemProduct
GraphQL query accepts an optionalshopId
argument that is recommended when looking up by slugdefaultParcelSize
field without needing to set the othersBreaking changes
None
Testing
Verify the described fixes. For the shop resolvers one, use this query with an admin token: