Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: full cart/checkout integration test #5976

Merged
merged 39 commits into from
Jan 8, 2020
Merged

test: full cart/checkout integration test #5976

merged 39 commits into from
Jan 8, 2020

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Dec 19, 2019 •
edited
Loading

Resolves #5518
Impact: critical
Type: bugfix|test

Issue

Need to test various mutations for cart/checkout

Solution

  • Add a test suite that runs though a full cart/checkout flow
  • Fixes a bug with shipping price calculations

Test Cases

  • As a singed in user from the beginning, add items to cart and checkout
  • As an anonymous user, add items to cart and checkout
  • An an anonymous user, add items to cart, sign in, reconcile carts, and checkout

Breaking changes

none

Testing

  1. Tests should pass

mikemurray and others added 19 commits December 19, 2019 14:20
@mikemurray
test: add query definition for AddCartItemsMutation
d99436d 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add query definition for CreateCartMutation
a1450d7 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add query definition for PublishProductsToCatalogMutation
60cc362 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add query definition for RemoveCartItemsMutation
840ba1f 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add query definition for SetShippingAddressOnCartMutation
572f210 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add query definition for UpdateCartItemsQuantityMutation
003f866 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add full cart integration test
328133e 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add _id field
e9f0e32 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add update fulfillment group options mutation definition
b8ac535 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add test to get available fulfillment methods
70053c1 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add mutation definition
8064c52 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add mutation definition
8d0bdcc 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add mutation definition
383b976 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add mutation definition
5bbad37 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
tests: add tests through placeOrder
c8589d1 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
Merge branch 'release-3.0.0' into test-5518-mikemurray-full-checkout-…
4d37d4e 
…integration
@kieckhafer
fix: recalculate shipping prices correctly
b25ed02 
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer
Merge branch 'test-5518-mikemurray-full-checkout-integration' of gith…
3cbd5da 
…ub.com:/reactioncommerce/reaction into test-5518-mikemurray-full-checkout-integration
@mikemurray
test: add email address to order capture
835bf4a 
Signed-off-by: Mike Murray <[email protected]>
@kieckhafer kieckhafer mentioned this pull request Dec 21, 2019
Merged
@mikemurray
Merge branch 'release-3.0.0' into test-5518-mikemurray-full-checkout-…
e968abf 
…integration
@mikemurray
test: add token field
7fc7fee 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add reconcile carts mutation definition
f10bdab 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add test for anonymous to authenticated checkout
4cc7528 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add email field
6eff9dd 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add anonymous cart query definition
cd5ed6f 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add set email on anonymous cart mutation definition
2dd8b7c 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add anonymous checkout test
e2227ee 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
refactor: renamed test file
3cca91f 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
refactor: renamed test file
285aa05 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] test: full cart/checkout integration test test: full cart/checkout integration test Jan 6, 2020
@mikemurray mikemurray requested a review from willopez January 6, 2020 22:15
@mikemurray mikemurray marked this pull request as ready for review January 6, 2020 22:15
willopez
willopez requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed, otherwise looking great.

tests/integration/api/mutations/checkout/anonymousCheckout.test.js Outdated Show resolved Hide resolved
tests/integration/api/mutations/checkout/anonymousCheckout.test.js Outdated Show resolved Hide resolved
willopez
willopez approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willopez willopez merged commit 6671611 into release-3.0.0 Jan 8, 2020
@willopez willopez deleted the test-5518-mikemurray-full-checkout-integration branch January 8, 2020 19:09
@rosshadden rosshadden mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemurray @willopez @kieckhafer