Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add integration tests for surcharge #5938

Merged

Conversation

trojanh
Copy link
Contributor

@trojanh trojanh commented Dec 18, 2019

Resolves #5937 & #5923
Impact: minor
Type: test|chore

Issue

Add integration tests for createSurcharge, updateSurcharge and deleteSurcharge mutations

@trojanh trojanh changed the title tests: Add integration test for createSurcharge tests: Add integration test for createSurcharge & deleteSurcharge Dec 18, 2019
@trojanh trojanh force-pushed the surcharge-integration branch from ba170df to f847982 Compare December 18, 2019 14:10
@trojanh trojanh marked this pull request as ready for review December 18, 2019 14:22
@trojanh trojanh changed the title tests: Add integration test for createSurcharge & deleteSurcharge tests: Add integration tests for createSurcharge & deleteSurcharge Dec 18, 2019
@mikemurray
Copy link
Member

@trojanh Would you mind adding taking #5923 and doing the updateSurcharge tests?

@trojanh
Copy link
Contributor Author

trojanh commented Dec 18, 2019

Sorry @mikemurray I had just checked the open PRs before starting this and later found that you already had similar issues assigned to yourself. I didn't mean to do overlapping work. If you haven't started working on the updateSurcharge test i dont mind completing it with this.

@mikemurray
Copy link
Member

@trojanh It's ok, I assigned myself to it but didn't start working on it since other things popped up in priority.

@mikemurray mikemurray self-requested a review December 18, 2019 18:39
@trojanh
Copy link
Contributor Author

trojanh commented Dec 18, 2019

@mikemurray feel free to review this now whenever you can. I have added the test for updateSurcharge mutation

@trojanh trojanh changed the title tests: Add integration tests for createSurcharge & deleteSurcharge tests: Add integration tests for surcharge Dec 18, 2019
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 324a6fa into reactioncommerce:release-3.0.0 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants