test: delete unused documents in afterAll #5903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trojanh <[email protected]>
trojanh
changed the title
Signed-off-by: trojanh <[email protected]>
trojanh
force-pushed
the
test-deleted-unused-documents
branch
3 times, most recently
from
9c42055 to
6353b90
Compare
Signed-off-by: trojanh <[email protected]>
trojanh
force-pushed
the
test-deleted-unused-documents
branch
from
6353b90 to
d60dc26
Compare
|
@trojanh If this is ready for review as is, then I approve. Even though it probably doesn't fix the memory leak, more cleanup is always good. |
|
thanks @mikemurray . |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5897
Impact: minor
Type: performance|test
Issue
In an effort to debug #5897 , I found these integration tests had some of the documents undeleted.