refactor: source Stripe API keys from ENV vars

.env.example

@@ -0,0 +1 @@
+STRIPE_API_KEY=YOUR_PRIVATE_STRIPE_API_KEY

src/plugins/payments-stripe/config.js

@@ -0,0 +1,10 @@
+import envalid from "envalid";
+
+const { str, testOnly } = envalid;
+
+export default envalid.cleanEnv(process.env, {
+  STRIPE_API_KEY: str({
+    desc: "A private Stripe API key",
+    devDefault: testOnly("YOUR_PRIVATE_STRIPE_API_KEY")
+  })
+});

src/plugins/payments-stripe/index.js

@@ -31,15 +31,6 @@ export default async function register(app) {
         listRefunds: stripeListRefunds
       }
     }],
-    settings: {
-      mode: false,
-      api_key: "",
-      public: {
-        publishable_key: "",
-        client_id: ""
-      },
-      connectAuth: {}
-    },
     registry: [
       // Settings panel
       {

src/plugins/payments-stripe/util/getStripeInstanceForShop.js

@@ -1,28 +1,13 @@
-import ReactionError from "@reactioncommerce/reaction-error";
-import Logger from "@reactioncommerce/logger";
+import config from "../config.js";
 import getStripeInstance from "./getStripeInstance.js";
-import getStripePackageForShop from "./getStripePackageForShop.js";
 
 /**
  * @summary Given a shop ID, gets an instance of the Stripe API configured with that shop's API key.
  * @param {Object} context The context object, with `collections.Packages` on it
- * @param {String} shopId The shop ID
  * @returns {Object} The Stripe SDK object
  */
-export default async function getStripeInstanceForShop(context, shopId) {
-  const stripePkg = await getStripePackageForShop(context, shopId);
-  const stripePkgSettings = (stripePkg || {}).settings || {};
+export default async function getStripeInstanceForShop(context) {
+  const { STRIPE_API_KEY } = config;
 
-  const stripeApiKey = stripePkgSettings.api_key;
-  if (!stripeApiKey) {
-    const stripeAccessToken = (stripePkgSettings.connectAuth || {}).access_token;
-    if (stripeAccessToken) {
-      Logger.warn("Using a Stripe access_token instead of an api_key is deprecated. Please set an API Key.");
-      return getStripeInstance(context, stripeAccessToken);
-    }
-
-    throw new ReactionError("not-configured", "Stripe is not configured properly. Please set an API Key.");
-  }
-
-  return getStripeInstance(context, stripeApiKey);
+  return getStripeInstance(context, STRIPE_API_KEY);
 }

src/plugins/payments-stripe/util/stripeCaptureCharge.js

@@ -15,7 +15,7 @@ export default async function stripeCaptureCharge(context, payment) {
     amount: formatForStripe(payment.amount)
   };
 
-  const stripe = await getStripeInstanceForShop(context, payment.shopId);
+  const stripe = await getStripeInstanceForShop(context);
 
   try {
     const captureResult = await stripe.charges.capture(payment.transactionId, captureDetails);

src/plugins/payments-stripe/util/stripeCreateAuthorizedPayment.js

@@ -57,7 +57,7 @@ export default async function stripeCreateAuthorizedPayment(context, input) {
     }
   } = input;
 
-  const stripe = await getStripeInstanceForShop(context, shopId);
+  const stripe = await getStripeInstanceForShop(context);
 
   // For orders with only a single fulfillment group, we could create a charge directly from the card token, and skip
   // creating a customer. However, to help make future charging easier and because we always have an email address and tracking

src/plugins/payments-stripe/util/stripeCreateRefund.js

@@ -16,7 +16,7 @@ import formatForStripe from "./formatForStripe.js";
 export default async function stripeCreateRefund(context, paymentMethod, amount, reason) {
   let result;
   try {
-    const stripe = await getStripeInstanceForShop(context, paymentMethod.shopId);
+    const stripe = await getStripeInstanceForShop(context);
 
     const refundResult = await stripe.refunds.create({ charge: paymentMethod.transactionId, amount: formatForStripe(amount), reason });
     Logger.debug(refundResult);

src/plugins/payments-stripe/util/stripeListRefunds.js

@@ -11,7 +11,7 @@ import getStripeInstanceForShop from "./getStripeInstanceForShop.js";
  * @private
  */
 export default async function stripeListRefunds(context, paymentMethod) {
-  const stripe = await getStripeInstanceForShop(context, paymentMethod.shopId);
+  const stripe = await getStripeInstanceForShop(context);
 
   let refundListResults;
   try {