Working integration tests #5732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
kieckhafer
previously requested changes
Oct 21, 2019
There was a problem hiding this comment.
Overall this looks good, tests pass, however it seems like there is some issue that's not finishing up the tests, so it stays running in CI for a long time.
It's been "running" for about 10 min after the tests have already passed:
EDIT: and now that it's been over 10 minutes, they have failed:
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Issue
Jest integration tests not working.
Solution
Tests now work. The main problem was that the
requireextension didn't work. That API is technically deprecated anyway, so we now have a different solution for importing from.graphqlfiles: a newimportAsStringfunction in theapi-utilspkg.After integration tests began working, they identified a bug in the
primaryShopIdquery, which is also fixed here. There were various other issues with the tests themselves and with theTestAppclass, just because of the other changes between 2.x and 3.0.0. Those are resolved.Testing
reactioncommerce/api-utils#4 will need to be merged and released, and then api-utils package bumped in this repo before you can test.
Verify all tests pass on CI.
Verify the API starts and works as expected.