chore: remove meteor app-tests #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
aldeed
approved these changes
Sep 16, 2019
mikemurray
approved these changes
Sep 16, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves parts of #5529
Impact: major
Type: chore
Issue
We are in the process of removing meteor from the node-app. There are a few meteor app-test files which we are currently refactoring one-by-one into unit tests, where necessary. The
app-testCI takes a long time to load, and there are frequent issues with these tests.Solution
Instead of removing these tests one by one as go through the process of demeteorization, we will remove them all here to allow for quicker dev, and no need to go back and deal with broken meteor tests that are / will soon be irrelevant. This also cuts CI running time, with the full process, including docker build and docker push, taking less than 20 minutes now:
Locally, tests run in under 9 minutes.
++
Breaking changes
None
Testing
test-apprunning