-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use SplitButton from Catalyst instead of ConrifmButton #5469
refactor: use SplitButton from Catalyst instead of ConrifmButton #5469
Conversation
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ateOrderStatusWithSplitButton
Signed-off-by: Erik Kieckhafer <[email protected]>
@reactioncommerce/design I'd like to show you how this works in action. It's a strange workflow, having to select something from the dropdown, and then also click the button. I feel like maybe the original way, where a dialog opens, is better. |
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ateOrderStatusWithSplitButton
@machikoyasuda @mikemurray This is updated to use the new There is another PR that is updating Catalyst inside of reaction to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a question in one of the files.
imports/plugins/core/orders/client/components/OrderCardFulfillmentGroupStatusButton.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #5421
Impact: minor
Type: refactor
Issue
At the time of original development,
SplitButton
was not yet available, therefore not used in places it should have been.Solution
Update the UI to use
SplitButton
where needed, since it's now available in Catalyst. Also updated this component from aClass
to afunction
component, and updated themutation
to use@apollo/react-hooks
.Breaking changes
None
Testing
SplitButton
component is now used in theFulfillment Group
section of the Orders AdminSplitButton
works by changing shipment status as it should