Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use SplitButton from Catalyst instead of ConrifmButton #5469

Merged
merged 12 commits into from
Aug 28, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Aug 20, 2019

Resolves #5421
Impact: minor
Type: refactor

Issue

At the time of original development, SplitButton was not yet available, therefore not used in places it should have been.

Solution

Update the UI to use SplitButton where needed, since it's now available in Catalyst. Also updated this component from a Class to a function component, and updated the mutation to use @apollo/react-hooks.

Breaking changes

None

Testing

  1. Create an Order
  2. See that the SplitButton component is now used in the Fulfillment Group section of the Orders Admin
  3. See that the SplitButton works by changing shipment status as it should

@kieckhafer
Copy link
Member Author

@reactioncommerce/design I'd like to show you how this works in action. It's a strange workflow, having to select something from the dropdown, and then also click the button. I feel like maybe the original way, where a dialog opens, is better.

@kieckhafer kieckhafer changed the title [BLOCKED] refactor: use SplitButton from Catalyst instead of ConrifmButton refactor: use SplitButton from Catalyst instead of ConrifmButton Aug 26, 2019
@kieckhafer kieckhafer requested a review from mikemurray August 26, 2019 22:08
@kieckhafer
Copy link
Member Author

@machikoyasuda @mikemurray This is updated to use the new ActionMenu, which is available in Catalyst 1.8.

There is another PR that is updating Catalyst inside of reaction to 1.7.3, so my PR will bump it even further. We should probably just update the other PR to use 1.8.0 as well.

#5473

@kieckhafer kieckhafer requested review from willopez and removed request for mikemurray and machikoyasuda August 27, 2019 22:14
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question in one of the files.

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kieckhafer kieckhafer merged commit 4302723 into develop Aug 28, 2019
@kieckhafer kieckhafer deleted the ref-kieckhafer-updateOrderStatusWithSplitButton branch August 28, 2019 16:35
@kieckhafer kieckhafer mentioned this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants