-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat bulk actions UI updates #5461
Conversation
…in an InlineAlert; Handle case where no products found; Chip spacing Signed-off-by: Christopher Shepherd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I filter by a file with no results sometimes I get this error
Invariant Violation: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
at invariant (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:199059:15)
at scheduleWork (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:218920:5)
at Object.enqueueSetState (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:210173:5)
at StyledComponent.Component.setState (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:86246:16)
at StyledComponent.componentWillReceiveProps (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:303309:10)
at callComponentWillReceiveProps (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:210445:14)
at updateClassInstance (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:210655:7)
at updateClassComponent (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:213698:20)
at beginWork (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:214648:16)
at performUnitOfWork (http://localhost:3000/packages/modules.js?hash=897806c6e7bfb4e7a703b564805f4bd2ce64eb7a:218316:12)
Other times I get 2 selected
when filtering by a file, but there doesn't seem to be any selected products.
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Christopher Shepherd <[email protected]>
imports/plugins/included/product-admin/client/components/ProductTable.js
Outdated
Show resolved
Hide resolved
…roducts if files removed Signed-off-by: Christopher Shepherd <[email protected]>
@willopez you can review + merge this! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor issue. My prouducts.csv
contains three product ids, 1 is an actual product and the other two are just made up. The text in the alert is incorrect, it should say 2 products were not found.
Also,
Seeing this console error:
Warning: Material-UI: the key `leftChip` provided to the classes property is not implemented in ProductGridItems.
You can only override one of the following: isVisible,isHidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Impact: minor
Type: bugfix
Issue
This includes the following UI fixes for Bulk Actions:
Breaking changes
n/a
Testing
Verify the above are properly implemented and styled