Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bodyParser to use individual method #5435

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

kieckhafer
Copy link
Member

Impact: minor
Type: chore

Issue

bodyParser() was presenting a warning on app startup because we were using it in a deprecated way

Solution

Update the code to conform to their updated standards by calling an individual method on bodyParser, instead of the entire bodyParser code.

Breaking changes

None

Testing

  1. Start the app and see that we no longer see the warning

Screenshot_8_7_19__12_55_PM

@kieckhafer kieckhafer requested a review from willopez August 7, 2019 19:55
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kieckhafer kieckhafer merged commit e684b7d into develop Aug 7, 2019
@kieckhafer kieckhafer deleted the ref-kieckhafer-updateToRemoveWarning branch August 7, 2019 21:00
This was referenced Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants