feat(producttable): add isvisible/hidden icons #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Machiko Yasuda <[email protected]>
machikoyasuda
force-pushed
the
feat-5392-status-icon
branch
from
3b7eddd to
47e3a72
Compare
Signed-off-by: Machiko Yasuda <[email protected]>
machikoyasuda
force-pushed
the
feat-5392-status-icon
branch
from
6b1b06d to
be0177a
Compare
cassytaylor
approved these changes
Aug 2, 2019
cshepherd
approved these changes
Aug 2, 2019
kieckhafer
reviewed
Aug 2, 2019
| isVisible: { | ||
| color: theme.palette.colors.forestGreen300, | ||
| fontSize: theme.typography.fontSize * 1.25, | ||
| marginRight: theme.spacing(1) |
There was a problem hiding this comment.
This is fine, but if the unit is 1 it's not required.
We should probably make a decision on whether to always use a number, even 1, or leave it blank if it's 1.
Doesn't matter to me either way, and will be a quick find / replace whichever way we decide.
There was a problem hiding this comment.
Ah, good to know. Add it to your future Spacing docs :)
kieckhafer
approved these changes
Aug 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5392
Impact: minor
Type: feature
Issue
#5392
Solution
- use https://github.com/TeamWertarbyte/mdi-material-ui icon, like the Tag table does - but use MUI styling, rather than Styled-Components (which is what the Tag table does)Breaking changes
No
Testing