Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: red textfields #5371

Merged
merged 1 commit into from
Jul 25, 2019
Merged

fix: red textfields #5371

merged 1 commit into from
Jul 25, 2019

Conversation

mikemurray
Copy link
Member

Impact: critical
Type: bugfix

Issue

Some text fields have the red error state, even though they contain valid data.

Solution

isValid can be true for success, false for error, and undefined for the default state.

Breaking changes

none

Testing

  1. Visit forms around the app, namely the product/variant editor form and see that they aren't red
  2. add valid/invalid data and ensure they have the correct error/success states where available

@mikemurray
fix: return undefined for unvalidated state
3add610 
isValid can be true for success, false for error, and undefined for the unvalidated state.

Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray requested a review from kieckhafer July 25, 2019 21:35
kieckhafer
kieckhafer approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 can confirm the red is dead

@kieckhafer kieckhafer merged commit 6558c68 into develop Jul 25, 2019
@kieckhafer kieckhafer deleted the fix-mikemurray-red-textfields branch July 25, 2019 22:04
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemurray @kieckhafer @machikoyasuda