(refactor): how to get reaction version #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maria Paktiti <[email protected]>
mpaktiti
force-pushed
the
refactor-mpaktiti-get-reaction-version
branch
from
a0bc375 to
4661610
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves -
Impact: minor
Type: docs
Issue
Our GitHub Issue Template is asking users to check their Reaction version by running
reaction -v. The Reaction CLI has been deprecated as of Reaction v2, therefore the template should instruct users to use an alternative.Solution
A script
versionwas added atpackage.jsonthat echoes the value of$npm_package_version.The Issue Template was updated with instructions to run
npm run version --silentin order to check the reaction version. The script output looks like this:> npm run version --silent 2.0.0-rc.10Breaking changes
None
Testing
Check the template offers the correct instructions (i.e.
npm run version --silent).