Allow the Invitations table to show invitations for all shops #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Loan Laux [email protected]
Impact: minor
Type: feature
Issue
I need to re-use the
Invitationstable in a custom plugin and show pending admin invitations for all shops at the same time. TheInvitationstable currently doesn't allow that.Solution
Make
Invitationstake theshopIdas a prop and allow for anullshop name value in the table.Breaking changes
The
Invitationstable component now requires ashopIdprop to show invitations for a given shop. If noshopIdis provided, the table will show invitations for all shops combined.Testing
Invitationswith ashopId, confirm that invitations are shown for this specific shop.Invitationswithout ashopId, confirm that invitations are shown for all combined shops.