fix: hide sidebar on new-shop page #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Loan Laux [email protected]
Impact: major
Type: bugfix
Issue
The sidebar is shown even when on the
/new-shoppage, which shouldn't be the case. When clicking on a sidebar link from the/new-shoppage, the basic routing thingy that I implemented will think that the current shop ID isnew-shop, resulting in users landing on pages like/new-shop/products, which obviously isn't desired.Solution
Make
useCurrentShopIdreturn no shop ID when thenew-shoppage is shown. This way, the sidebar will be hidden, and any other part usinguseCurrentShopIdwill know that there's currently no shop ID selected.Breaking changes
None.
Testing
/new-shoppage.