chore: don't use querystring arg for shop type

[loan-laux]

Signed-off-by: Loan Laux [email protected]

Impact: minor
Type: refactor|chore

Issue

In one of my previous pull requests, I introduced a separate /new-shop page for users to create new shops. This page would get the desired shop type (then passed as a createShop mutation parameter) from the querystring. To get the current user to create a primary shop, you would redirect them to /new-shop?primary=true, or you'd omit the querystring altogether for a secondary shop.

Since the createShop mutation already creates a primary shop if none exists, or a merchant shop if a primary was already created, there is no reason for us to explicitly pass the desired shop type when calling createShop. We can simply call createShop without a shop type, which will result in the same experience to end-users, with less confusion for developers.

Solution

Remove the use of the querystring parameter to set the shop type. Don't pass the shop type when calling createShop, letting the mutation figure out on its own whether to create a primary shop or a merchant shop.

Breaking changes

None.

Testing

1. Create a shop on a fresh new install. The created shop should be of type primary in the Shops MongoDB collection.
2. With this primary shop created, create a second shop. This new shop should be of type merchant in the Shops MongoDB collection.

[rosshadden]

👍 Thanks