-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Tax sourcing #258
Edit Tax sourcing #258
Conversation
Signed-off-by: Sven Bretschneider <[email protected]>
Signed-off-by: Sven Bretschneider <[email protected]>
Might also fix reactioncommerce/reaction#6231 |
Just noticed this PR. I've actually just submitted api-plugin-taxes-flat-rate#3 to fix this issue. It also fixes reaction#6231. I think @derBretti's solution of sending null values instead of empty strings right from @aldeed let me know if you want me to remove this server-side value check, since @derBretti's changes will be sufficient. However, PR alone won't fix reaction#6231, since the |
@willopez While you're at it, it would be great if you could also review and merge this one that's been sitting here for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @derBretti!
Resolves #257 , #259
Impact: minor
Type: feature
Issue
Solution
Breaking changes
none
Testing