Translate custom emoji references from IRC to Discord #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an IRC user uses a custom emoji reference (e.g. :testemoji:), it should be translated into the actual emoji for Discord users, instead of appearing in plain text. This also adds tests to ensure other emoji-like phrases do not get converted or cause the bot to crash.
|
As a note: I think all server-specific emoji have |
ekmartin
approved these changes
Jul 1, 2017
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IRC user uses a custom emoji reference (e.g. :testemoji:), it should be translated into the actual
emoji for Discord users, instead of appearing in plain text.
This also adds tests to ensure other emoji-like phrases do not get converted or cause the bot to crash.
(Discord users enter something such as
:testemoji:, which gets converted into e.g.<:testemoji:987654321>– we already translate this to IRC, stripping the angle brackets and extra digits, but don't translate the other way as I would expect.)Addresses issue #250.