Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: getDatasetAtEvent, getElementAtEvent and getElementsAtEvent props are removed #845

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

dangreen
Copy link
Collaborator

@dangreen dangreen commented Nov 4, 2021

BREAKING CHANGE: getDatasetAtEvent, getElementAtEvent and getElementsAtEvent props are removed,
utils with the same names can used instead

… props are removed

getDatasetAtEvent, getElementAtEvent and getElementsAtEvent props are removed, utils with the same
names can used instead

BREAKING CHANGE: getDatasetAtEvent, getElementAtEvent and getElementsAtEvent props are removed,
utils with the same names can used instead
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #845 (ab5bd24) into master (f7a81e6) will decrease coverage by 1.41%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   66.04%   64.63%   -1.42%     
==========================================
  Files           5        5              
  Lines         162      164       +2     
  Branches       38       33       -5     
==========================================
- Hits          107      106       -1     
- Misses         33       38       +5     
+ Partials       22       20       -2     
Impacted Files Coverage Δ
src/types.ts 0.00% <ø> (ø)
src/utils.ts 77.77% <ø> (-7.94%) ⬇️
src/index.tsx 40.00% <50.00%> (+4.28%) ⬆️
src/chart.tsx 74.13% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a81e6...ab5bd24. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.cjs 759 B (-14.15% 🔽) 15 ms (-14.15% 🔽) 59 ms (+9.29% 🔺) 74 ms
dist/index.modern.js 654 B (-15.84% 🔽) 13 ms (-15.84% 🔽) 89 ms (+38.09% 🔺) 102 ms

@dangreen dangreen merged commit 6a9b2a7 into master Nov 4, 2021
@dangreen dangreen deleted the refactor-click-handlers branch November 4, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants