Wrong TS type for plugins prop

[burtek]

react-chartjs-2/src/types.ts

Line 14 in 7070c25

plugins?: Chart.PluginServiceRegistrationOptions[];

Shouldn't plugins type be Chart.Plugin[] rather than PluginServiceRegistrationOptions? See TS types of chart.js:

https://github.com/chartjs/Chart.js/blob/8e68481ec4e29599660332f58967f439fb2ef17c/types/index.esm.d.ts#L3490-L3499

[El-bana]

Any workarounds found other than changing the node module file until this is fixed?

ok I used this to solve it temporarily

plugins={([plugin] as unknown as PluginOptionsByType<any>)}

[burtek]

@El-bana I just went with as any for now, I still need to refactor that PoC part of my project ;p

[dangreen]

@burtek Hi. Can you try [email protected]? Is this issue still there?

[burtek]

Hi. For

return <Scatter data={data} options={options} plugins={[backgroundPlugin]} />;

it works if I do const backgroundPlugin: Plugin = { ... } but doesn't for const backgroundPlugin: Plugin<'scatter'> = { ... } - TS is reporting:

Type 'Plugin<"scatter", AnyObject>[]' is not assignable to type 'Plugin<keyof ChartTypeRegistry, AnyObject>[]'.
  Type 'Plugin<"scatter", AnyObject>' is not assignable to type 'Plugin<keyof ChartTypeRegistry, AnyObject>'.
    Types of property 'beforeTooltipDraw' are incompatible.

I'm fine with Plugin as it doesn't really change much, so the issue seems fixed for me, but just wanted to point this out

[burtek]

@dangreen @El-bana looks like README needs to be changed, too?

[dangreen]

@burtek Can you try [email protected] ?

[burtek]

@dangreen So far looks and works good to me :)

[Maks6831]

<Chart
width={"100%"}
height={"100%"}
type={props.isLine ? "line" : "bar"}
data={data}
options={options as any}
style={{ width: "100%", height: "100%" }}
/> this works for me - the error was failing checks even though the graph was working properly the way i had made it