Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 -- Remove --open call on npm start #47

Closed
2 tasks done
sthzg opened this issue Aug 11, 2016 · 3 comments
Closed
2 tasks done

V1 -- Remove --open call on npm start #47

sthzg opened this issue Aug 11, 2016 · 3 comments
Assignees

Comments

@sthzg
Copy link
Member

sthzg commented Aug 11, 2016

As brought up in generator-react-webpack #266

V1

  • remove open() method in server.js
  • log dev server address to console after the inital webpack build is ready
@sthzg
Copy link
Member Author

sthzg commented Aug 11, 2016

@weblogixx it will now print the following info to the shell after the initial build (on V1 of the template).

bildschirmfoto 2016-08-11 um 12 14 13

@weblogixx
Copy link
Member

Seems like a nice addition. Do you think we should wait a bit until more 1.x features are there or do you want to push it directly? I do not think that we will have any more advanced features for the current stable, so pushing would ok.

@sthzg
Copy link
Member Author

sthzg commented Aug 11, 2016

I think waiting is absolutely okay. I just want to merge it so that I can delete the feature branch. Besides being a topic in the browser sync issue it's not such an important change, after all.

@sthzg sthzg closed this as completed in #48 Aug 11, 2016
sthzg added a commit that referenced this issue Aug 11, 2016
This PR removed calling `open()` in `server.js` and added output with the dev server urls after the initial Webpack compilation.

Closes #47
@sthzg sthzg removed the actionable label Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants