Updated functionality related to PostCSS - #307 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bumped postcss and postcss-loader versions - removed deprecated custom logic related to setting up PostCSS - updated tests As communicated in #307 and on the related PR from @stylesuxx on the template repo we can use PostCSS` more recent config file feature instead of modifying our config. If users prompt the PostCSS question with yes, deps for postcss and postcss-loader are added to their package.json. The updated tests check that - postcss and postcss-loader deps are added on PostCSS yes - postcss and postcss-loader deps are not added on PostCSS no - postcss.config.js is copied to the project root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR depends on react-webpack-generators/react-webpack-template#77. Its test will pass once the PR from the template repo is released.
As communicated in #307 and on the related PR from @stylesuxx on the
template repo we can use PostCSS` more recent config file feature
instead of modifying our config.
If users prompt the PostCSS question with yes, deps for postcss and
postcss-loader are added to their package.json.
The updated tests check that