Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostCSS update and fix #313

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

stylesuxx
Copy link
Contributor

  • Added template file for postcss config which provides infrastructure to add postcss plugins
  • Fixed and improved attachment of the postcss-loader to th webpack config
  • Updated README regarding postcss usage

Thanks to @sthzg for testing postcss and importLoader functionality.

Fixes #307

* Use newest template
* Updated Esprima
* Added template file for postcss config which provides infrastructure to add postcss plugins
* Fixed and improved attachment of the postcss-loader to th webpack config
* Updated README regarding postcss usage
@coveralls
Copy link

coveralls commented Nov 25, 2016

Coverage Status

Coverage increased (+0.05%) to 96.124% when pulling 0f89280 on stylesuxx:master into 9c68254 on react-webpack-generators:master.

@sthzg
Copy link
Member

sthzg commented Nov 25, 2016

@stylesuxx thanks for the updates. I will checkout the commit tonight and plan to manually test it in all variations (with all preprocessors with and without cssmodules). Yesterday I have tested it with CSS and LESS (both w/ and wo/ css modules), but I think it would be good to also check S(A|C)SS and Stylus once, especially to make sure that the @imports are picked up correctly.

As soon as that is done we can merge and publish a new V4 pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants