Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 -- Update for template v2.0.1-5 #306

Merged
merged 3 commits into from
Nov 22, 2016

Conversation

stylesuxx
Copy link
Contributor

Primarly needed to update the way, the postcss related stuff is attached since it is attached to the webpack config, which has changed.

@stylesuxx stylesuxx changed the title Update for template v2.0.1-5 V4 -- Update for template v2.0.1-5 Nov 22, 2016
@coveralls
Copy link

coveralls commented Nov 22, 2016

Coverage Status

Coverage increased (+0.04%) to 96.19% when pulling e4ef5bd on stylesuxx:master into b581e5b on react-webpack-generators:master.

@sthzg
Copy link
Member

sthzg commented Nov 22, 2016

@stylesuxx changes are looking good. does this fix the PostCSS part completely (from the template side)? Then I'd merge and publish the next pre-release. Otherwise I'd merge and wait a little before publishing.

@stylesuxx
Copy link
Contributor Author

I have not tested the postcss part yet, but I can do that in the evening and report back - if I did not completely mess up the webpack config it should still be working - at least the tests pass regarding the attachment of the postcss functionality. I remember you mentioned that something was not working properly - can you link me to an issue?

@sthzg
Copy link
Member

sthzg commented Nov 22, 2016

That is a good question. AFAIK in the V4 generator the PostCSS part was reported to be buggy. I couldn't find a Github issue, but this comment serves as an indicator that there were problems. Maybe @weblogixx still has a bit of context on that. Otherwise I will also test a setup and see what it does/does not do.

I will merge this to 2.x now so that it can be tested against the template w/ the necessary modifications in this PR.

@sthzg sthzg merged commit a2bd75a into react-webpack-generators:master Nov 22, 2016
@sthzg
Copy link
Member

sthzg commented Nov 22, 2016

FYI: I tested an installation w/ PostCSS enabled and filed an error on this issue #307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants