fix: cleanup transaction even if action wasn't handled

react-navigation · Dec 25, 2019 · f462d67 · f462d67
1 parent 873afec
commit f462d67
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/core/src/NavigationContainer.tsx b/packages/core/src/NavigationContainer.tsx
@@ -123,9 +123,11 @@ const Container = React.forwardRef(function NavigationContainer(
       isTransactionActiveRef.current = true;
       transactionStateRef.current = navigationState;
 
-      callback();
-
-      isTransactionActiveRef.current = false;
+      try {
+        callback();
+      } finally {
+        isTransactionActiveRef.current = false;
+      }
 
       return transactionStateRef.current;
     });