feat(#162): fabric support [reintroduce] #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add JS Flow spec - make android viewmanager to conform to codegen-ed specs - make android viewmanager extend ReactViewManager instead of ViewGroupManager - add codegen-ed spec to make viewmanager work also in old arch - use install_module_dependencies in the podspec to install deps on both new and old architectures - add subclass of RCTViewComponentView - use fabric implementation when RCT_NEW_ARCH_ENABLED flag is true - set RN peerDependency to be version >= 0.71
…, add pointerEvents example
|
nice! note that this is not strictly required to support fabric, this library works out of the box with the interop layer. |
|
Hey @brentvatne, we have a use case to use MaskedView in 0.73 and if I understand correctly, the MaskedView works with interop layer from 0.74 |
frontendsenior
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR with fabric support for RN >= 0.71 was reverted a few days ago, because of lint issues on pipeline. This PR reintroduces fabric changes with lint issues fixed
cc: @brentvatne
Test Plan
yarnin the root directoryyarn test:lintyarn test:flowyarn test:typescriptyarnin theexampledirectorynewArchEnabled=falseinexample/android/gradle.properties./gradlew cleaninexample/androidnewArchEnabled=trueinexample/android/gradle.propertiesnpx pod-install)RCT_NEW_ARCH_ENABLEDflag (RCT_NEW_ARCH_ENABLED=1 npx pod-install)