Replies: 16 comments 58 replies
-
|
Ok |
Beta Was this translation helpful? Give feedback.
-
|
OK I added: And get this error: |
Beta Was this translation helpful? Give feedback.
-
|
OK this did not work once I cleaned up and started over. So Still looking for a solution. use_frameworks! is what we need to support long term it seems. |
Beta Was this translation helpful? Give feedback.
-
|
OK - for this to work I got it working with use_framework!
....later....
Ok this works. Here is my whole Podfile |
Beta Was this translation helpful? Give feedback.
-
|
This part is off to me:
It is my understanding that bitcode is not only on the way out, but that it will be specifically disallowed with Xcode 14 ...and this is interesting because we are about to have hermes work with use_frameworks, but it will require bitcode to be disabled: facebook/react-native#34148 Just to say, I would explore disabling bitcode again - but getting react-native-maps to work with use_frameworks is a fantastic result, thanks for posting up how to do it for others - really appreciated! |
Beta Was this translation helpful? Give feedback.
-
|
@mikehardy - Is the (Also, for what it's worth, the app builds for me on Simulator and real device with |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I may have tagged the wrong person? Will make a new comment and tag one of the maintainers of |
Beta Was this translation helpful? Give feedback.
-
|
Do not do "Patch for 1.2.0". when using the fix for podspec. |
Beta Was this translation helpful? Give feedback.
-
|
@Simon-TechForm - You moved this issue to a discussion, so I'm wondering whether you have any input here. Should we expect Also, see the patch that @billnbell proposed above. Is this something we can get in a future version? It's only a few lines of code, but I'm not sure the implications with In practical terms, react-native-firebase now requires |
Beta Was this translation helpful? Give feedback.
-
|
@go-sean-go I will be happy to share my input, but it might not be the input you are looking for :) While "should we expect support at any point?" is a very broad question to answer, I can tell that it is not a priority right now. I've noticed that @mikehardy and a few others are putting in some great work getting Regarding the patch - I'm not sure about the implications either and currently don't have the time to test them, which is why you probably won't see it in any imminent releases. That being said, the more people that try out the proposed change (or other changes) and report back in this discussion, the easier it will be to merge support for |
Beta Was this translation helpful? Give feedback.
-
|
Hey! 👋 I think this might be easier than it seems. Also, while use_frameworks is experimental in the sense that flipper and hermes and new architecture have trouble with it, hermes is now solid with it and react-native itself has worked with it forever. Stated differently, there are a few configs now where it is stable, and a few that are experimental - it's a spectrum not binary. So let's move this farther along the spectrum ;-) The whole Podfile thing above boils down to adding one search path to header search paths:
...all the rest of it appears extraneous to me, boilerplate stuff that is not the change. If I'm reading it right, that path right there is the change. Given that this is a header that should come from a dependency of this module itself ( ) then it seems reliable to assume it will be there, and the real change is this tiny thing added to the podspec:s.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/Google-Maps-iOS-Utils/src/Heatmap\"" }...possibly with path updates on the import statements to drop the prefix as @RyanMan56 mentions below. That will need a quick test with and without use_frameworks Why? Because use_frameworks specifically changes how the headers from different pods are symlinked or not into each other's spaces So if you just force that to be in the header search path, it will be there for both cases. I think it can be that easy, most of the use_frameworks changes are like this - in my experience trying to drive these things, they are all just about managing header / symbol visibility changes between the two styles. Similar changes: So: Action Item:Some interested person here needs to get busy with patch-package and the podspec for this module in a toy demo project reproducer, where they patch in that podspec change to add the path, maybe patch import paths, and allow easy testing of use_frameworks in use or not. That's the PR and the proof, then this is done ? It could be done... |
Beta Was this translation helpful? Give feedback.
-
|
thanks @mikehardy - I agree that you are probably correct. As @RyanMan56 says below, this patch does work. Would love to get this out and fixed. Happy to help test. |
Beta Was this translation helpful? Give feedback.
-
|
You might need to add $(inherited) as well. |
Beta Was this translation helpful? Give feedback.
-
|
this works for me |
Beta Was this translation helpful? Give feedback.
-
|
@billnbell Thanks for sharing your solution, I followed it and was able to get React Native Maps working with I had a small issue where patch-package was unable to parse your patch, so here's what worked for me: |
Beta Was this translation helpful? Give feedback.
-
|
Yeah this works for me too. |
Beta Was this translation helpful? Give feedback.
-
|
@billnbell I have been grateful as I watch you help push use_frameworks compatibility out into the ecosystem, it's a big help, thank you. For this particular one I'm really curious about the possibly-minimal solution of just changing podspec:
because if that works, then it's a tiny "does no harm" fix that might be a merge-able PR, whereas the existing patch is languishing (even though it does seem to work) |
Beta Was this translation helpful? Give feedback.
-
|
@mikehardy Are you saying add this to |
Beta Was this translation helpful? Give feedback.
-
|
I think react-native-google-maps.podspec, but nothing beats actually trying it :-). Hopefully that works+helps |
Beta Was this translation helpful? Give feedback.
-
|
OK did a bunch of testing. The line above is not right. Here is a patch for react-native-maps+1.3.1.patch |
Beta Was this translation helpful? Give feedback.
-
|
🤔 I was under the impression any fiddling with the pod build type was a workaround for pods that didn't handle use_frameworks gracefully and the solution was more along the lines of finding the headers that aren't linked, then adding them to the compile arguments as the PR did. I don't need any fiddling around with build types in my apps at least. So I'm surprised that PR didn't work. I must admit I do not use this module myself so I don't have any sort of reproduction rig set up nor can I justify the time to do so. I love making things work and would like to dig in but I'm stretched thin, apologies. |
Beta Was this translation helpful? Give feedback.
-
|
Those instructions are not usable and do not work. My solution of setting static library and fixing the podspec does work on 0.69 and 0.70. I am using it daily and perfecto for me. I would regis your Podfile or send it here and I can debug it for you. Or create a sa please repo in GitHub showing the issue and I will fix it for you. |
Beta Was this translation helpful? Give feedback.
-
|
I needed to fix the podspec and set the static library from static framework. This is because react-native-maps seems to have to be a library to get it linked in correctly. I am not the author of this library and unsure how to make it work as a static framework. But I do agree that those couple lines + the podspec works for me. |
Beta Was this translation helpful? Give feedback.
-
I wonder if that fact that I'm using 0.67.2 has something to do with this not working for me then. I have a separate track of upgrading RN that I may need to include on this effort to get it working. Please see my Podfile in the comment here. |
Beta Was this translation helpful? Give feedback.
-
|
For hermes + use_frameworks at least, I think 0.69 (currently 0.69.6 as I type this) is a minimum requirement. In general since this is a bit of "new" popular use case for react-native I'd strive to stay current, though I recognize the native parts of the upgrade are a bit involved as new architecture was rolled out in 68/69/70 - but https://react-native-community.github.io/upgrade-helper/ hopefully leads the way |
Beta Was this translation helpful? Give feedback.
-
|
Thanks to @mikehardy and @billnbell I've just released v.1.3.2-beta.1 with the proposed changes. This will make for easy testing for anyone requiring |
Beta Was this translation helpful? Give feedback.
-
|
The errors I'm seeing. Thanks for helping here @billnbell! |
Beta Was this translation helpful? Give feedback.
-
|
Podfile below |
Beta Was this translation helpful? Give feedback.
-
|
Try removing Since we already have that in the podspec now. Does that help? |
Beta Was this translation helpful? Give feedback.
-
Thanks for your help here. I'm going to use a previous version of RN Firebase Analytics for now that doesn't require this implementation, upgrade RN, and come back to this. I'd consider this an issue related to using RN 0.67.2 unless you want me to go back and try the above just for sanity's sake before merging @Simon-TechForm. |
Beta Was this translation helpful? Give feedback.
-
|
I agree we are only saying it works with 0.69 and 0.70 of RN. |
Beta Was this translation helpful? Give feedback.
-
|
I am unsure about Expo. Are you using managed or unmanaged expo? Make sure you do not make the changes above. Only take the beta, and my new notes. They are in the PR:
|
Beta Was this translation helpful? Give feedback.
-
|
Hey. I'm inputting some more information regarding expo. I'm using managed expo. I use both react-native-firebase and react-native-maps. I updated to "@react-native-firebase/...": "15.4.0 and updated their plugins array in app.json as https://rnfirebase.io/#expo guides. After that trying to build encountered the same error as @aindong. Then I dug deeper and noticed that react-native-google-maps.podspec has |
Beta Was this translation helpful? Give feedback.
-
|
It looks like you need to set your minimum deploy target higher then. Expo must have some mechanism to do this, and it seems like this is not the forum, the expo troubleshooting forum should help, or their docs (which don't seem to have it? https://docs.expo.dev/versions/v46.0.0/config/app/#ios) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you. I will continue to expo forums. Just outputted information regarding aindong's comment and expo as noticed it was mentioned. I will post additional information here when I get this working in expo so that it might help others stumbling here. |
Beta Was this translation helpful? Give feedback.
-
|
I managed to get this working by combining @billnbell solution with expo plugin and custom plugin (through which podfile can be edited). This is not yet well tested, but basically this is just using already available solutions with expo. This was needed for me as I use react-native-firebase (which uses use use_frameworks!) and react-native-maps. Using: app.json change withReactNativeMaps.js If I don't use best practices please inform me and if someone doesn't get it working like this I don't have enough information to help further. I just connected puzzle pieces |
Beta Was this translation helpful? Give feedback.
-
|
I have the exact same configuration as mentionned above from @fuelkoy |
Beta Was this translation helpful? Give feedback.
-
|
This worked perfectly! Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Did you guys also get a blank map on iOS? on Android it worked fine |
Beta Was this translation helpful? Give feedback.
-
|
"@react-native-firebase/analytics": "^17.5.0", "react-native-maps": "1.3.2", "expo": "~48.0.18", Thanks, it works in the above versions as well. |
Beta Was this translation helpful? Give feedback.
-
|
when i run my app locally - everything works, but when i build using eas, i still get this error. Who has same issue ? |
Beta Was this translation helpful? Give feedback.
-
|
Expo SDK 47 coming out soon with React Native Maps 0.31.1 → 1.3.2. This should make some of the above workaround for expo unnecessary, but will test when it lands |
Beta Was this translation helpful? Give feedback.
-
Does not work with react-native-maps 1.3.2 and latest Expo SDK47 :( |
Beta Was this translation helpful? Give feedback.
-
|
Managed to get it working on Expo 47 with React Native Maps 1.3.2. First, reset the Then in Think the key issue may be Expo upgrading the deploy target from iOS 12 in Expo 46 to iOS 13 in Expo 47. |
Beta Was this translation helpful? Give feedback.
-
|
Without the script from above? Did not work for me |
Beta Was this translation helpful? Give feedback.
-
|
Yes, needs still the script from above. But "deploymentTarget": "13.0", can be removed from from app.json |
Beta Was this translation helpful? Give feedback.
-
|
It works with the script above, if you use devclients remember to "prebuild --clean" to regenerate the podfile |
Beta Was this translation helpful? Give feedback.
-
|
Facing the same issue. After upgraded to SDK47 and eas, my IOS builds getting fail. Run fastlane section last logs: › Compiling build Pods/react-native-google-maps » react-native-google-maps-dummy.m
› Compiling react-native-maps Pods/react-native-google-maps » RCTConvert+GMSMapViewType.m
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapWMSTileManager.m
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapWMSTile.m
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapUrlTile.m
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapURLTileManager.m
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapPolylineManager.m
❌ (node_modules/react-native-maps/ios/AirGoogleMaps/AIRGoogleMapPolylineManager.m:17:9)
15 | #import <React/RCTViewManager.h>
16 | #import <React/UIView+React.h>
> 17 | #import "RCTConvert+AirMap.h"
| ^ 'RCTConvert+AirMap.h' file not found
18 | #import "AIRGoogleMapPolyline.h"
19 |
20 | @interface AIRGoogleMapPolylineManager()
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapPolyline.m
› Compiling react-native-maps Pods/react-native-google-maps » AIRGoogleMapPolygonManager.m
Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'React-Codegen' from project 'Pods')
Run script build phase 'Start Packager' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Tilleli' from project 'Tilleli')
Run script build phase 'Bundle React Native code and images' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Tilleli' from project 'Tilleli')
Run script build phase '[CP-User] Generate app.config for prebuilt Constants.manifest' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'EXConstants' from project 'Pods')
Run script build phase '[CP-User] Generate app.manifest for expo-updates' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'EXUpdates' from project 'Pods')
Run script build phase 'Create Symlinks to Header Folders' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'RCT-Folly' from project 'Pods')
▸ ** ARCHIVE FAILED **
▸ The following build commands failed:
▸ CompileC /Users/expo/Library/Developer/Xcode/DerivedData/Tilleli-fzmqitxhjmwestgpefzrhsophzqr/Build/Intermediates.noindex/ArchiveIntermediates/Tilleli/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/react-native-google-maps.build/Objects-normal/arm64/AIRGoogleMapPolylineManager.o /Users/expo/workingdir/build/node_modules/react-native-maps/ios/AirGoogleMaps/AIRGoogleMapPolylineManager.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-google-maps' from project 'Pods')
▸ (1 failure)
** ARCHIVE FAILED **
The following build commands failed:
CompileC /Users/expo/Library/Developer/Xcode/DerivedData/Tilleli-fzmqitxhjmwestgpefzrhsophzqr/Build/Intermediates.noindex/ArchiveIntermediates/Tilleli/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/react-native-google-maps.build/Objects-normal/arm64/AIRGoogleMapPolylineManager.o /Users/expo/workingdir/build/node_modules/react-native-maps/ios/AirGoogleMaps/AIRGoogleMapPolylineManager.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'react-native-google-maps' from project 'Pods')
(1 failure)
Exit status: 65
+-------------+-------------------------+
| Build environment |
+-------------+-------------------------+
| xcode_path | /Applications/Xcode.app |
| gym_version | 2.210.0 |
| sdk | iPhoneOS16.0.sdk |
+-------------+-------------------------+
Looks like fastlane ran into a build/archive error with your project
It's hard to tell what's causing the error, so we wrote some guides on how
to troubleshoot build and signing issues: https://docs.fastlane.tools/codesigning/getting-started/
Before submitting an issue on GitHub, please follow the guide above and make
sure your project is set up correctly.
fastlane uses `xcodebuild` commands to generate your binary, you can see the
the full commands printed out in yellow in the above log.
Make sure to inspect the output above, as usually you'll find more error information there
[stderr] [!] Error building the application - see the log above
Error: Fastlane build failed with unknown error. See logs for the "Run fastlane" and "Xcode Logs" phases for more information.
Fastlane errors in most cases are not printed at the end of the output, so you may not find any useful information in the last lines of output when looking for an error message.I'm currently using plugins: [
[
'expo-build-properties',
{
ios: {
useFrameworks: 'static'
}
}
],
],Please help me! How can I solve it? |
Beta Was this translation helpful? Give feedback.
-
|
expo-firebase-analytics is deprecated, use instead react-firebase-analytics and try again ? |
Beta Was this translation helpful? Give feedback.
-
Tried. Didn't work. I think the problem with |
Beta Was this translation helpful? Give feedback.
-
|
see answer from @fuelkoy above, and then retry. I had the same issue and his solution made my build succeed |
Beta Was this translation helpful? Give feedback.
-
|
Installed beta but still getting build errors on iOS with react native firebase |
Beta Was this translation helpful? Give feedback.
-
|
Facing same issue, on SDK47 |
Beta Was this translation helpful? Give feedback.
-
|
Well here's my experience after a long night of frustration you have to choose these versions in order to make it work. I used eas with, metal m1 for the build because the intel ones were full. Rn-Firebase all "@react-native-firebase/analytics": "~15.4.0",
"@react-native-firebase/app": "~15.4.0",
"@react-native-firebase/crashlytics": "~15.4.0",react-native-maps, yes the expo doctor will complain that it is wrong but doesn't seem we have any other choice "react-native-maps": "1.3.2",And the rest just copy and paste from this great answer: At the end the Map on iOS became blank and on Android just fine, so for iOS I used the default provider : apple map OH GOD I HATE NATIVE BUILDS! |
Beta Was this translation helpful? Give feedback.
-
|
For anyone following this discussion who might be interested in a solution that doesn't require any workarounds, I've just released v1.6.0 which should support |
Beta Was this translation helpful? Give feedback.
-
|
For me the "out of the box" solution is not working. Not using expo, with the following setup, I get a build error. package.json Podfile The steps for clearing cache / pods / modules are:
|
Beta Was this translation helpful? Give feedback.
and others
-
Summary
What is the solution when using use_frameworks! As you know firebase is moving to this, and this one fails.
See - for an explanation.
invertase/react-native-firebase#6332
@mikehardy might have some thoughts here... But I know he is working on Firebase and other things to get it all working with latest Firebase.
Reproducible sample code
Steps to reproduce
None
Expected result
None
Actual result
None
React Native Maps Version
1.1.0
What platforms are you seeing the problem on?
iOS (Apple Maps), iOS (Google Maps)
React Native Version
0.69.3
What version of Expo are you using?
Not using Expo
Device(s)
iPhone
Additional information
No response
Beta Was this translation helpful? Give feedback.
All reactions