Road to v0.65.0 - RC2 phase #235

kelset · 2021-06-09T14:58:53Z

This issue serves to track the status of work to reach 0.65.0.

Current latest: 0.65.0-rc.2
Changelog draft PR: #234

Known issues

iOS: Some reports of Folly dual symbols preventing ios from building successfully. Investigation is ongoing.

Commits (and PRs) to cherry pick

Bump flipper deps to from 0.91 to 0.93 (ios) - facebook/react-native@848d599
Android: upgrading to OkHttp from 4.9.0 to 4.9.1 to fix java.lang.NullPointerException: bio == null crash facebook/react-native@6caec9d
Fix support for blobs larger than 64 KB on Android facebook/react-native@f00e348
fix: update to @jest/create-cache-key-function@27 facebook/react-native@2f477b1
(not sure) bump local files (yarn.lock/podfile) to Hermes 0.8.1 https://github.com/facebook/hermes/releases/tag/v0.8.1
bump to Metro (via lockfile)

Non-blocking for RC release

Hermes Support for ARM64 simulator & Catalyst: merged as facebook/hermes@62e5abe - needs a Hermes release?
Allow PlatformColor to work with RCTView border colors facebook/react-native@c974cbf
Accessible colors for DynamicColorIOS facebook/react-native@4b9d9dd

Local commits to backport to main

facebook/react-native@cae0637
facebook/react-native@f6accd2 (need to check if this is actually needed in main)
facebook/react-native@5aae7fc

Please limit your comments to reports of issues encountered with the RC and cherry pick suggestions. No ETA currently for when 0.65.0 will be released.

The text was updated successfully, but these errors were encountered:

swrobel · 2021-06-14T22:47:48Z

I'm unable to build my app on iOS using Xcode 12.5 (intel macOS 11.4). It built fine on 0.64.2. I've used react-native-clean-project and the result is still the same after reinstalling everything.

CompileC Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o Pods/RCT-Folly/folly/Singleton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RCT-Folly' from project 'Pods')
    cd Pods
    export LANG\=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -target x86_64-apple-ios9.0-simulator -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -std\=c++14 -stdlib\=libc++ -fmodules -fmodules-cache-path\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Werror\=deprecated-objc-isa-usage -Werror\=objc-root-class -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DPOD_CONFIGURATION_DEBUG\=1 -DDEBUG\=1 -DCOCOAPODS\=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -g -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path Index/DataStore -IBuild/Products/Debug-iphonesimulator/RCT-Folly/include -IPods/Headers/Private -IPods/Headers/Private/RCT-Folly -IPods/Headers/Public -IPods/Headers/Public/DoubleConversion -IPods/Headers/Public/RCT-Folly -IPods/Headers/Public/fmt -IPods/Headers/Public/glog -IPods/Headers/Public/libevent -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/Headers/Public/libevent/event -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources-normal/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources -FBuild/Products/Debug-iphonesimulator/RCT-Folly -DFOLLY_NO_CONFIG -DFOLLY_MOBILE\=1 -DFOLLY_USE_LIBCPP\=1 -DFOLLY_HAVE_PTHREAD\=1 -Wno-comma -Wno-shorten-64-to-32 -Wno-documentation -w -Xanalyzer -analyzer-disable-all-checks -include Pods/Target\ Support\ Files/RCT-Folly/RCT-Folly-prefix.pch -MMD -MT dependencies -MF Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.d --serialize-diagnostics Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.dia -c Pods/RCT-Folly/folly/Singleton.cpp -o Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:648:29: error: no matching function for call to 'compile'
  constexpr auto compiled = detail::compile<Args...>(S());
                            ^~~~~~~~~~~~~~~~~~~~~~~~
Pods/RCT-Folly/folly/Singleton.cpp:161:25: note: in instantiation of function template specialization 'fmt::v7::format<FMT_COMPILE_STRING, folly::Range<const char *>, 0>' requested here
  auto const msg = fmt::format(FOLLY_FMT_COMPILE(
                        ^
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:582:16: note: candidate template ignored: requirement 'is_compile_string<FMT_COMPILE_STRING>::value' was not satisfied [with Args = <folly::Range<const char *>>, S = FMT_COMPILE_STRING]
constexpr auto compile(S format_str) -> detail::compiled_format<S, Args...> {
               ^
Pods/Headers/Public/fmt/fmt/compile.h:589:6: note: candidate template ignored: could not match 'const Char [N]' against 'FMT_COMPILE_STRING'
auto compile(const Char (&format_str)[N])
     ^
1 error generated.

beetlebum · 2021-06-17T13:08:59Z

I'm experiencing an error on 0.65.0-rc.1 building for iOS

Intel Mac with Xcode 12.5
With Hermes enabled
Flipper upgraded to 0.93 via Podfile use_flipper!({ 'Flipper' => '0.93.0' }) (same error occurs without this)

IPHONEOS_DEPLOYMENT_TARGET = 12.3

duplicate symbol 'folly::detail::str_to_bool(folly::Range<char const*>*)' in:
    /...Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /...Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
duplicate symbol 'folly::makeConversionError(folly::ConversionCode, folly::Range<char const*>)' in:
    /...Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /...Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
ld: 2 duplicate symbols for architecture x86_64

From the Podfile.lock:

    - RCT-Folly (= 2021.04.26.00)

  - Flipper (0.93.0):
    - Flipper-Folly (~> 2.6)
    - Flipper-RSocket (~> 1.4)
  - Flipper-Boost-iOSX (1.76.0.1.11)
  - Flipper-DoubleConversion (3.1.7)
  - Flipper-Fmt (7.1.7)
  - Flipper-Folly (2.6.7):
    - Flipper-Boost-iOSX
    - Flipper-DoubleConversion
    - Flipper-Fmt (= 7.1.7)
    - Flipper-Glog
    - libevent (~> 2.1.12)
    - OpenSSL-Universal (= 1.1.180)
    ```


I have cleaned the project, reinstalled pods etc.

Any ideas? Thanks

janicduplessis · 2021-06-17T14:53:03Z

@beetlebum Also noticed this error, seems to be related with the updated Flipper-DoubleConvertion pod. Setting back the version to what it was before fixes it for me.

use_flipper!("Flipper" => "0.93.0", "Flipper-DoubleConversion" => "1.1.7")

I think the problem is because the double conversion version that we use in react native and the one in flipper is different now and clang can’t dedupe de symbols properly anymore. Cc @PeteTheHeat

diego-paired · 2021-06-17T14:58:56Z

@beetlebum Also noticed this error, seems to be related with the updated Flipper-DoubleConvertion pod. Setting back the version to what it was before fixes it for me.

use_flipper!("Flipper" => "0.93.0", "Flipper-DoubleConversion" => "1.1.7")

I think the problem is because the double conversion version that we use in react native and the one in flipper is different now and clang can’t dedupe de symbols properly anymore. Cc @PeteTheHeat

thanks so much, I'll give it a go

birkir · 2021-06-23T20:42:03Z

Im having a hard time knowing what was cherry picked and what not, so just for clarity as it’s not in the latest RC:

These two for DynamicColorIOS

Allow PlatformColor to work with RCTView border colors (facebook/react-native@c974cbf)
Accessible colors for DynamicColorIOS (facebook/react-native@4b9d9dd)

beetlebum · 2021-06-25T09:43:25Z

We've been testing 0.65rc-2 but have had to go back to 0.64 due to a few blocking issues, that I'm listing here as they might affect other people:

Without "Flipper-DoubleConversion" => "1.1.7" added to the Podfile, iOS could not be compiled with the error mentioned above, regardless of Flipper version (0.94.1 or 0.93)
When running the app on a device via Testflight, it would crash at launch with a generic error:

8   libobjc.A.dylib               	0x00000001a51255d0 objc_exception_rethrow + 40 (objc-exception.mm:604)
9   CoreFoundation                	0x0000000191343904 CFRunLoopRunSpecific + 808 (CFRunLoop.c:3257)
10  Paired                        	0x0000000100eaadc8 +[RCTCxxBridge runRunLoop] + 264 (RCTCxxBridge.mm:324)
11  Foundation                    	0x00000001926fcdb0 __NSThread__start__ + 848 (NSThread.m:724)

Android could not be built or tested due to Reanimated 2 not supporting it: Does not build using react-native 0.65.0-rc.0 on Android software-mansion/react-native-reanimated#2131
Issues with FBReactNativeSpec during iOS builds, usually solved by cleaning the build

geraintwhite · 2021-07-05T15:09:22Z

facebook/react-native@2f477b1 allows jest 27 to work with react-native. Please can we include this?

SConaway · 2021-07-05T23:21:10Z

Really hope this hasn't been mentioned here, and I'm sorry if it has been. Just thought it should get fixed for when 0.65.0 is released

On a brand-new 0.65.0-rc.2 app, without Hermes, I am unable to create a release build for the iOS Simulator when building from an Intel Mac either in XCode or the CLI (in case it matters, I'm running Monterey dev beta 2 with XCode 13.0 beta 1, but it doesn't work on release XCode 12.5 either).

Output from react-native doctor:

``` $ yarn react-native doctor yarn run v1.22.10 $ /Users/steven/AwesomeProject/node_modules/.bin/react-native doctor Common ✓ Node.js ✓ yarn ✖ Watchman - Used for watching changes in the filesystem when in development mode [seems not to have any effect on anything, still works] - Version found: 2021.06.07.00 - Version supported: 4.x

Android
✓ JDK
✓ Android Studio - Required for building and installing your app on Android
✖ Android SDK - Required for building and installing your app on Android [seems not to have any effect on anything, still works]

Versions found: N/A
Version supported: 30.0.2
✓ ANDROID_HOME

iOS
✓ Xcode - Required for building and installing your app on iOS
✓ CocoaPods - Required for installing iOS dependencies
✓ ios-deploy - Required for installing your app on a physical device with the CLI

Errors: 2
Warnings: 0

</details>

Additionally, see this issue / comment for more details: https://github.com/facebook/react-native/issues/31179#issuecomment-831872601

dulmandakh · 2021-07-07T12:56:34Z

Android crash fix Android: upgrading to OkHttp from 4.9.0 to 4.9.1 to fix java.lang.NullPointerException: bio == null crash facebook/react-native#31822

[edited by @mikehardy to add...] merged as facebook/react-native@6caec9d

mikehardy · 2021-07-08T16:12:40Z

@kelset just a note that I edited the actual description way up at the top to re-point the Hermes + iOS + Apple Silicon build ~~PR to point to the current one with activity just today. Looks like it will land shortly, appears to me it is in final-fixups mode with main contributors all collaborating + pushing it through~~ - PR landed!! Just needs a Hermes release I suppose? Commit reference noted at the top for release tag inspection when+if. Nice, hermes team.

teniii · 2021-07-08T17:16:44Z

Hello. I've upgraded to RN 0.65.0-rc.2 and after removing completely the RN Reanimated and all the libraries depending on it, I've managed to build on Android, but when launching, the app crashes (both with and without Hermes). Seems there is something wrong with the MMKV module installing. I don't know if here is the right place to write, but I don't know where else i can ask this question. Hope this is on the topic, helping for releasing.

The log in Flipper contains:

Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x2 in tid 8277 (create_react_co), pid 8159
Build fingerprint: 'google/sdk_gphone_x86_arm/generic_x86_arm:9/PSR1.180720.122/6736742:userdebug/dev-keys'
Revision: '0'
ABI: 'x86'
Cause: null pointer dereference 
   eax 00000002  ebx c94ea784  ecx 00000002  edx be978244
   edi be9782c8  esi c94bd2c0
   ebp be9781a8  esp be978180  eip c94bf56b

And then the backtrace:

19:48:00.256
8295
DEBUG
    #00 pc 0002856b  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libjscexecutor.so (facebook::jsc::JSCRuntime::valueRef(facebook::jsi::Value const&)+27)
19:48:00.256
8295
DEBUG
    #01 pc 00029165  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libjscexecutor.so (facebook::jsc::JSCRuntime::setValueAtIndexImpl(facebook::jsi::Array&, unsigned int, facebook::jsi::Value const&)+69)
19:48:00.256
8295
DEBUG
    #02 pc 00021372  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libmmkvnative.so (install(facebook::jsi::Runtime&)+178)
19:48:00.256
8295
DEBUG
    #03 pc 00022252  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libmmkvnative.so (Java_com_reactnativemmkv_MmkvModule_nativeInstall+114)
19:48:00.256
8295
DEBUG
    #04 pc 005f6a17  /system/lib/libart.so (art_quick_generic_jni_trampoline+71)
19:48:00.256
8295
DEBUG
    #05 pc 005f0bd2  /system/lib/libart.so (art_quick_invoke_static_stub+418)
19:48:00.256
8295
DEBUG
    #06 pc 000a2f5f  /system/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+239)
19:48:00.256
8295
DEBUG
    #07 pc 0029bb22  /system/lib/libart.so (art::interpreter::ArtInterpreterToCompiledCodeBridge(art::Thread*, art::ArtMethod*, art::ShadowFrame*, unsigned short, art::JValue*)+338)
19:48:00.256
8295
DEBUG
    #08 pc 00293cc8  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1048)
19:48:00.256
8295
DEBUG
    #09 pc 005bdb1f  /system/lib/libart.so (MterpInvokeStatic+207)
19:48:00.256
8295
DEBUG
    #10 pc 005e2d21  /system/lib/libart.so (ExecuteMterpImpl+14625)
19:48:00.256
8295
DEBUG
    #11 pc 000773cc  /dev/ashmem/dalvik-classes2.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk!classes2.dex (deleted) (com.reactnativemmkv.MmkvModule.install+8)
19:48:00.256
8295
DEBUG
    #12 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.256
8295
DEBUG
    #13 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.256
8295
DEBUG
    #14 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.256
8295
DEBUG
    #15 pc 005bdb1f  /system/lib/libart.so (MterpInvokeStatic+207)
19:48:00.256
8295
DEBUG
    #16 pc 005e2d21  /system/lib/libart.so (ExecuteMterpImpl+14625)
19:48:00.256
8295
DEBUG
    #17 pc 00000eea  /dev/ashmem/dalvik-classes4.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk!classes4.dex (deleted) (com.app.AppJSIPackage.getJSIModules+50)
19:48:00.256
8295
DEBUG
    #18 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.256
8295
DEBUG
    #19 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.256
8295
DEBUG
    #20 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.256
8295
DEBUG
    #21 pc 005bd434  /system/lib/libart.so (MterpInvokeInterface+1444)
19:48:00.256
8295
DEBUG
    #22 pc 005e2da1  /system/lib/libart.so (ExecuteMterpImpl+14753)
19:48:00.256
8295
DEBUG
    #23 pc 0041cb3e  /dev/ashmem/dalvik-classes.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk (deleted) (com.facebook.react.ReactInstanceManager.createReactContext+346)
19:48:00.256
8295
DEBUG
    #24 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.256
8295
DEBUG
    #25 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.257
8295
DEBUG
    #26 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.257
8295
DEBUG
    #27 pc 005bd926  /system/lib/libart.so (MterpInvokeDirect+342)
19:48:00.257
8295
DEBUG
    #28 pc 005e2ca1  /system/lib/libart.so (ExecuteMterpImpl+14497)
19:48:00.257
8295
DEBUG
    #29 pc 0041c9c8  /dev/ashmem/dalvik-classes.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk (deleted) (com.facebook.react.ReactInstanceManager.access$1100)
19:48:00.257
8295
DEBUG
    #30 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.257
8295
DEBUG
    #31 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.257
8295
DEBUG
    #32 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.257
8295
DEBUG
    #33 pc 005bdb1f  /system/lib/libart.so (MterpInvokeStatic+207)
19:48:00.257
8295
DEBUG
    #34 pc 005e2d21  /system/lib/libart.so (ExecuteMterpImpl+14625)
19:48:00.257
8295
DEBUG
    #35 pc 0041c0c8  /dev/ashmem/dalvik-classes.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk (deleted) (com.facebook.react.ReactInstanceManager$5.run+140)
19:48:00.257
8295
DEBUG
    #36 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.257
8295
DEBUG
    #37 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.257
8295
DEBUG
    #38 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.257
8295
DEBUG
    #39 pc 005bd434  /system/lib/libart.so (MterpInvokeInterface+1444)
19:48:00.257
8295
DEBUG
    #40 pc 005e2da1  /system/lib/libart.so (ExecuteMterpImpl+14753)
19:48:00.257
8295
DEBUG
    #41 pc 000ca806  /system/framework/boot.vdex (java.lang.Thread.run+12)
19:48:00.257
8295
DEBUG
    #42 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.257
8295
DEBUG
    #43 pc 0026c50e  /system/lib/libart.so (art::interpreter::EnterInterpreterFromEntryPoint(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*)+126)
19:48:00.257
8295
DEBUG
    #44 pc 005a93fd  /system/lib/libart.so (artQuickToInterpreterBridge+1277)
19:48:00.257
8295
DEBUG
    #45 pc 005f6aed  /system/lib/libart.so (art_quick_to_interpreter_bridge+77)
19:48:00.257
8295
DEBUG
    #46 pc 005f0a02  /system/lib/libart.so (art_quick_invoke_stub+338)
19:48:00.257
8295
DEBUG
    #47 pc 000a2f4e  /system/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+222)
19:48:00.257
8295
DEBUG
    #48 pc 004d3209  /system/lib/libart.so (art::(anonymous namespace)::InvokeWithArgArray(art::ScopedObjectAccessAlreadyRunnable const&, art::ArtMethod*, art::(anonymous namespace)::ArgArray*, art::JValue*, char const*)+89)
19:48:00.257
8295
DEBUG
    #49 pc 004d44b7  /system/lib/libart.so (art::InvokeVirtualOrInterfaceWithJValues(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, _jmethodID*, jvalue*)+471)
19:48:00.257
8295
DEBUG
    #50 pc 0050944c  /system/lib/libart.so (art::Thread::CreateCallback(void*)+1484)
19:48:00.257
8295
DEBUG
    #51 pc 0008f065  /system/lib/libc.so (__pthread_start(void*)+53)
19:48:00.257
8295
DEBUG
    #52 pc 0002485b  /system/lib/libc.so (__start_thread+75)

sertony · 2021-07-10T20:12:55Z

Hey, we’d like to have the following PR code in the upcoming release: facebook/react-native#31789

It fixes the support for blobs larger than 64 KB on Android (check the issue: facebook/react-native#31774)

How can we accomplish it? Apparently it requires to trigger Facebook team to start reviewing it.

teniii · 2021-07-12T13:05:08Z

Hello. I've upgraded to RN 0.65.0-rc.2 and after removing completely the RN Reanimated and all the libraries depending on it, I've managed to build on Android, but when launching, the app crashes (both with and without Hermes). Seems there is something wrong with the MMKV module installing. I don't know if here is the right place to write, but I don't know where else i can ask this question. Hope this is on the topic, helping for releasing.

Hello.
I come with an update. After removing the MMKV library, I've launched the app and immediately the bundle crashed with the following message:

/RN065RC2/node_modules/metro-hermes-compiler/src/emhermesc.js:77
          throw ex;
          ^

RuntimeError: abort(TypeError: Cannot read property 'toUpperCase' of undefined). Build with -s ASSERTIONS=1 for more info.
    at process.abort (/RN065RC2/node_modules/metro-hermes-compiler/src/emhermesc.js:440:13)
    at process.emit (node:events:406:35)
    at emit (node:internal/process/promises:136:22)
    at processPromiseRejections (node:internal/process/promises:242:25)
    at processTicksAndRejections (node:internal/process/task_queues:97:32)
Process terminated. Press <enter> to close the window

At this point, not being able to find other similar issues with this error, I've decided to test a new dummy React-Native project, to see if the issues is in my existing setup. I've followed the instructions presented in the releases page https://github.com/facebook/react-native/releases and the error is still occurring (with and without hermes) inside the newly created project. Is this a known issue?

kelset · 2021-07-12T13:18:33Z

@teniii if the error still occurs in a freshly generated project:

npx react-native init RN065RC2 --version 0.65.0-rc.2

Then it's likely that it's something with your existing setup.

a-eid · 2021-07-14T05:47:58Z

@kelset issue happens with a freshly generated project.

kelset · 2021-07-14T08:16:46Z

Understood - looks like we have a x3 confirmation (tenii, a-eid, tido64) of this metro-hermes-compiler/src/emhermesc error being thrown - so it's something we'll have to pay attention to when preparing the next RC. We are still waiting on Hermes for that.

mweststrate · 2021-07-14T08:33:49Z

I *think* I experienced this once, because I had either an old version of node, or an old version of ws package locked in my lockfile / resolutions. Might be totally unrelated, just sounded familiar.

…

On Wed, 14 Jul 2021, 09:16 Lorenzo Sciandra, ***@***.***> wrote: Understood - looks like we have a x3 confirmation (tenii, a-eid, tido64) of this metro-hermes-compiler/src/emhermesc error being thrown - so it's something we'll have to pay attention to when preparing the next RC. We are still waiting on Hermes for that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBDAJFVBBWSIUROZX3TTXVBXTANCNFSM46MHDFRQ> .

a-eid · 2021-07-14T08:58:00Z

@mweststrate could be the issue, I'm using v12.16.3, will try to update to >= LTS 14.17.13, test and report back.

sertony · 2021-07-15T07:36:30Z

@kelset Hi! We've managed to successfully merge this blob fix for Android into the master:
facebook/react-native@f00e348

Can we cherry-pick it to the upcoming 0.65.0 release now? Thanks.

teniii · 2021-07-15T16:13:03Z

I think I experienced this once, because I had either an old version of node, or an old version of ws package locked in my lockfile / resolutions. Might be totally unrelated, just sounded familiar.
…
On Wed, 14 Jul 2021, 09:16 Lorenzo Sciandra, @.***> wrote: Understood - looks like we have a x3 confirmation (tenii, a-eid, tido64) of this metro-hermes-compiler/src/emhermesc error being thrown - so it's something we'll have to pay attention to when preparing the next RC. We are still waiting on Hermes for that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBDAJFVBBWSIUROZX3TTXVBXTANCNFSM46MHDFRQ .

I've checked and I use v16.3.0 for Node. I don't know if this is the cause, but I can say that on this version it doesn't work.

kelset · 2021-07-15T16:41:34Z

yeah I think @tido64 was on Node14 and saw it happening too, so probably it's not related to the Node version

hsavit1 · 2021-07-16T11:58:03Z

@kelset seems like hermes 0.8.1 was released a few days ago https://github.com/facebook/hermes/releases/tag/v0.8.1 , can you update the description?

kelset · 2021-07-16T12:41:13Z

@hsavit1 I'm not sure I know what you mean, the top post is already updated to reflect that Hermes 0.8.1 is out.

Update on the metro-hermes-compiler issue: we have a PR with a fix that needs to be merged&released: facebook/metro#687

grabbou · 2021-07-16T13:06:01Z

Update on the release: I've cherry-picked few commits, passing over to @Titozzz to wrap up the rest.

Titozzz · 2021-07-16T13:50:03Z

facebook/react-native#31872 Has been created
TLDR for people following along this issue:
We are waiting for facebook/metro#687 to get merged, then ideally we want to bump the yarn.lock on metro in the CLI and then bump the yarn.lock from react-native to the the latest CLI, then we should be good for RC3

kelset · 2021-07-20T16:54:13Z

bump for Metro to cherry pick: facebook/react-native@cfdc4fe

kelset · 2021-07-23T16:09:49Z

RC3 is out, moving conversation over here: #238

kelset added release status Information about an upcoming or ongoing release rc Release candidate pre-release labels Jun 9, 2021

kelset mentioned this issue Jun 9, 2021

Road to v0.65 Discussion #223

Closed

38 tasks