Upcoming v0.64.2 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

PRs to merge:

• fix: update to @jest/create-cache-key-function@27 facebook/react-native#30637
• fix: codegen - project paths with spaces facebook/react-native#31141 -> facebook/react-native@b2e2f43
• Add mocks to fix: handleException is not a function (#29849) facebook/react-native#30027
• Fix cli bundle platform for Mac Catalyst in react-native-xcode.sh facebook/react-native#31062

Ready for cherry-pick:

• [Fix] Android: font-family is not apply when secureTextEntry is true facebook/react-native#30164 -> facebook/react-native@00d9dea
• [iOS] Use relative paths for pod spec to keep checksum stable facebook/react-native#31195 this was closed mentioning this as solution -> facebook/react-native@bdfe2a5
• facebook/react-native@310a6bc
• facebook/react-native@3399896
• facebook/react-native@0e9296b
• facebook/react-native@291cc95
• facebook/react-native@b0e8c1e

Issues to resolve:

• Unable to find JSIModule for class UIManager facebook/react-native#31245
• [0.64.0] archive fails for release due to invalid check for custom ENTRY_FILE facebook/react-native#31282
• 0.64 stable new template fails when using use_frameworks! facebook/react-native#31149

[myckhel]

i feel the previous discussion #221 has less meaning.
after all only 5 commits were pushed to the v0.64.1 stack.

[kelset]

@myckhel the reason why 0.64.1 was so small is that we wanted to quickly address the Xcode 12.5 problem which was a real blocker for a lot of developers.

[mikehardy]

Issue facebook/react-native#31245 just got a resolution!
Please please cherry pick facebook/react-native@b0e8c1e and thank you :-)

[danilobuerger]

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

[haralddoderer]

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

It would be nice if there was some kind of patch or a workaround available until we get the next release. I also still use 0.64.1 and I am afraid that lot's of dependencies then might break on updating. A backport to 0.64.1 would also be welcomed.

@kelset I just want to say thank you for all the hard work you invest. Hope you can help us here.

[sanduluca]

Please cherry pick facebook/react-native@00d9dea
This is very annoying to see that your styles are not working properly.
Thank you for your work. ❤🔥

[riccardonucleare]

Please cherry pick: facebook/react-native#31457
Quite an important issue to add.

[mikehardy]

@riccardonucleare that issue is not closed, there is no commit landed on master, it is not a valid cherry-pick request. From the top of this issue

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

I think best course is to focus effort on getting it merged then it's time to head here and request a pick

[AstroCorp]

merge this fix please :/

facebook/react-native#29099

[mikehardy]

@AstroCorp this is for cherry-picks, which implies there is a commit to cherrypick. That is a PR, it is not merged, there is no commit.

[capJavert]

Issue facebook/react-native#31245 just got a resolution!
Please please cherry pick facebook/react-native@b0e8c1e and thank you :-)

@kelset the issue that @mikehardy mentioned seems to be a pretty big blocker too judging by the amount of emojis the issue got in that short time frame. Maybe its worth doing a speedy release here too?

@kelset sorry for interruption but any updates to this? Any chance or ETA when this could be released because I think lots of people are having trouble because of this. Tnx!

[savv]

It would be great to have an ETA, if it's non-committal. It would help us decide whether we should push through for 0.64, or stay with 0.63 for our next release, which we are trying to get out. We are also blocked on facebook/react-native#31245

[kelset]

Folks I share your frustration but I hope you can understand that I'm not working on this full time, neither is @grabbou - and the FB team asked us to focus our (limited) attention to 0.65.

I want to get around to do the 0.64.2 release at some point but I don't know when I will have time for it.

[savv]

Hi, if it helps, I made a branch where I started from tag v0.64.1 and cherry-picked the seven commits listed at the top, under "Ready for cherry-pick:". I ran node ./scripts/publish-npm.js --nightly and it seems to have built (of course, it failed uploading :-)).

The branch is here: https://github.com/savv/react-native/tree/savv-0-64-2

[yedidyak]

Hi, facebook/react-native#31245 is a serious issue for us as well, it's blocking our adoption of 0.64. Is there any ETA for this to be released?

Thanks for all you do for the community!

[Shahafku]

Hi, thanks a lot for all your amazing work

We're experiencing a serious issue with facebook/react-native#31245, which is affecting our users badly.
An ETA for this will be appricicated

Thanks

[mikehardy]

That's an issue link not a commit hash? There are no etas in open source

[yedidyak]

This is the commit that solves it, in master: facebook/react-native@b0e8c1e, it was referenced above.

I appreciate that there's no definite ETA, but could you add any information that would help us understand whether we should be reverting to 0.63 or to hope for a new release containing this soon?

Thanks again

[mikehardy]

There is a comment saying they are focused on 65. I would not wait or use the fork above.

[yedidyak]

I understand, but this isn't a new feature, it's a single commit to solve a serious regression introduced in 0.64.0. Wouldn't it make sense to solve it in 0.64.2 without adding new features?

[mikehardy]

Discussions of 'should' in open source prompt invitations to commit yourself to the ongoing maintenance of the project, to handle releases etc without any form of compensation other than reputational benefit, over long periods of time. Is that what you intend? If not there is a reputational cost to asking other uncompensated individuals repeatedly to work for you. That's just open source. Above, someone has already done the open source thing and provided a temporary fork, which is magnificent. Revert, do the work, or wait. I'm not aware of other open source options.

[savv]

Hi all, I'm trying publish a temporary version, which is still building here. It cherrypicks only facebook/react-native@b0e8c1e into stable-0.64 (i.e. into 0.64.1).

If it succeeds, you will be able to use it like this in your package.json: "react-native": "npm:[email protected]". I haven't tested it yet, but will report back if it works!

I followed the steps in publish-npm.js:

1. Developer: git checkout 0.XY-stable
2. git cherry-pick b0e8c1e
3. change package name to react-native-savv so I can publish my own NPM
4. push to my own remote
5. create a release v0.64.2 here

[savv]

Update: I published [email protected] and successfully built an ios/android app, but haven't tested it extensively yet.

[DanijelBojcic]

Unfortunately Android release build doesn't work with [email protected]

[savv]

Unfortunately Android release build doesn't work with [email protected]

Hi Danijel, what failed for you? I have so far been able to build an app and it went through testing successfully.

[DanijelBojcic]

It would just hang on the splash screen.
Luckily I managed to fix it.
If in monorepo make sure you update every react-native version to "npm:[email protected]".
Then I got Invariant Violation: Module RCTDeviceEventEmitter is not a registered callable module and fixed it with facebook/react-native#28801 (comment)

Don't know if it will break something else, if yes I will update this comment.

[savv]

Thanks for the report. Do let me know if you run into any other issues so we all know if it's safe to use!

[kelset]

Hey folks, I've been working on this patch (finally got some time 😅) and here's a brief update: I managed to cherry pick cleanly:

• facebook/react-native@00d9dea
• facebook/react-native@0e9296b
• facebook/react-native@291cc95
• facebook/react-native@b0e8c1e
• facebook/react-native@d754bde

And sadly these other commits had conflicts so I didn't cherry pick them (at least for now):

• facebook/react-native@3399896
• facebook/react-native@310a6bc
• facebook/react-native@bdfe2a5
• facebook/react-native@b2e2f43

Now we'll proceed with testing, next week it's likely that we'll publish the patch release.

[kelset]

@satya164 @sunnylqm I've tested locally on my machine and I can't repro - also, given how Satya is on Node 14 and I'm on Node 12 I think we can exclude that it's "a known Node 12 issue".

Moreover, bumping to codegen 0.0.7 is something that we can't do as it was a cause of issues during the RC phase (we had to rollback from it: facebook/react-native@e7e4b00) so I'll hide the comments to keep the conversation on the next patch. That said if there's an issue in the main repo about it please keep the investigation going over there 🤗 There's probably something going on that should be addressed

[danilobuerger]

Please cherry-pick facebook/react-native@d754bde

[kelset]

@danilobuerger I was able to cherry pick cleanly so added to the list above 👍

[aliaksandr-kazarez]

Could you please cherry-pick facebook/react-native@6ccd0cd

[danilobuerger]

@aliaksandr-kazarez do you know why the build tools weren't updated to api level 30?

[aliaksandr-kazarez]

Nope unfortunately. Would try to figure it out.

[mikehardy]

I would more be curious why buildTools are still in there. They shouldn't be, they actually trigger android studio lint. But that's for a react-native issue

[kelset]

for future memory, this one is something we should try to cherry pick: facebook/react-native#31622

re:

Could you please cherry-pick facebook/react-native@6ccd0cd

No I don't think we'd cherry pick that into a patch release, since it's a bump mostly for CI stuff and the template. You'd still have to do the bump on your local project.

[imshreyansh]

@kelset Sir when will the patch release 0.64.2 will be available ?

[walterholohan]

facebook/react-native#31245 is also blocking us from upgrading to 0.64. 🙏 for 0.64.2 soon

[dulmandakh]

• facebook/react-native@502b819

[kelset]

@dulmandakh cherry picked and also did a local version of facebook/react-native@cdd0256 to address a CLI small issue.

Testing ongoing

[kelset]

hey folks - 0.64.2 is out now with a few fixes, in particular the JSI one facebook/react-native@b0e8c1e so I hope it will be a good release for y'all 🤗