Upcoming v0.64.1 cherrypicks discussion

[grabbou]

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.0 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

PRs to merge:

• fix: update to @jest/create-cache-key-function@27 facebook/react-native#30637
• fix: codegen - project paths with spaces facebook/react-native#31141
• Add mocks to fix: handleException is not a function (#29849) facebook/react-native#30027

Ready for cherry-pick:

• (Security related fix): facebook/react-native@33ef82c
• [Fix] Android: font-family is not apply when secureTextEntry is true facebook/react-native#30164 -> facebook/react-native@00d9dea
• [iOS] Use relative paths for pod spec to keep checksum stable facebook/react-native#31195 this was closed mentioning this as solution -> facebook/react-native@bdfe2a5
• facebook/react-native@310a6bc
• facebook/react-native@3399896
• facebook/react-native@0e9296b
• facebook/react-native@291cc95
• facebook/react-native@36b58a8

Issues to resolve:

• Unable to find JSIModule for class UIManager facebook/react-native#31245
• [0.64.0] archive fails for release due to invalid check for custom ENTRY_FILE facebook/react-native#31282
• 0.64 stable new template fails when using use_frameworks! facebook/react-native#31149
• New RN project will not build on Xcode 12.5 Beta 3 facebook/react-native#31179

---

Edit by @kelset to update the status of PRs/commits/issues.

[elicwhite]

@grabbou, can you help make a list of all the PRs we need to merge that were already cherry picked into 0.64?

[grabbou]

@grabbou, can you help make a list of all the PRs we need to merge that were already cherry picked into 0.64?

@TheSavior, here is the list of commits I have applied on 0.64-stable that were not merged to master at that time:

• Restore refresh spinner fix facebook/react-native#30978
• Update React.podspec to require cocoapods >= 1.10.1 facebook/react-native#31134
• Fixing the git attrs for all the people and all the files and all future 🙌  facebook/react-native#31128

[mayconline]

i'm problem with text input , when focusing on text input, it opens the keyboard the first time, but if you close the keyboard, and try to click on the text input again, the keyboard does not open again.

exists one issue open, but not resolution yet - facebook/react-native#30746

[alexco2]

Hello,
Would it be possible to cherrypick this?
facebook/react-native#30737
This is a fix that would enable support for section list for the library react-native-collapsible-tab-view.

[mikehardy]

@alexco2 the commit hash is the important bit: facebook/react-native@310a6bc

[alexco2]

Thank you! I'm new to this whole process :)

[mikehardy]

If this is not already in the list, I think facebook/react-native#31010 (update Flipper) is important, because Flipper was not published to mavenCentral until 0.75.x and jcenter is going away meaning builds will break by default with react-native 0.64 unless it's updated (or 0.65 is released) - commit facebook/react-native@3399896

[mikehardy]

This is just context but I did a deep dive on "jcenter/bintray is going away" to see if I could purge react-native-device-info module of jcenter uses - including the example app and it appears yoga's 'proguard-annotations' artifact is the key to it all. There are 3 items total

1- flipper itself (requested above)
2- flipper dependency on fbjni-android-only (fixed in flipper 0.79+, so we actually need a newer one than is even on main dev branch but wait...)
3- flipper dependency on yoga progaurd-annotations which is still published on jcenter only but tracked here and will require a still-newer flipper unless they publish old artifacts on jitpack or mavenCentral

[kelset]

@mikehardy good info, would you mind also mentioning those here? react-native-community/discussions-and-proposals#331

[stigi]

I'd like to nominate this PR that fixes dimensions after rotation on Android and that didn't make it into 0.64.0 yet:

• [Android] Update the cached dimensions when orientation changes facebook/react-native#30324

[kbrandwijk]

I would love to see this one make its way into 0.64.1, as there really is no good workaround: facebook/react-native#30164
A (low risk?) fix to Android fontstyling of placeholder texts for secureEntry TextInput fields.

[myckhel]

Please what are the plans for RN 0.64.1?
Could it be the version of TurboModule support?

Can't really wait to have turbomodule enabled.

[pvinis]

This seems useful, as the issue happened with 64.0. facebook/react-native#30027

[eliw00d]

PRs to merge:

• facebook/react-native#31195

This PR was closed in favor of facebook/react-native@bdfe2a5. So, that should make it into 0.64.1, right? This is holding us back at the moment.

[Ashoat]

Would be great to include facebook/react-native@291cc95. Without this, Hermes crashes on Android don't log the error that causes the crash, which makes debugging really difficult.

Additional context:

• Discussion in SIGSEGV hermesFatalErrorHandler -- Out of Memory (OOM) facebook/hermes#439
• This commit was previously requested for 0.64.0 but unfortunately didn't make it

[kelset]

updated top post with the commits/issues/PRs mentioned so far. The Xcode 12.5 fix commit is still in the works so we'll have to wait for that before proceeding.

[elicwhite]

We need to get this security related fix into the next patch release for 0.64: facebook/react-native@33ef82c

I'll add it to the list in the OP.

[robertying]

Could we have this PR facebook/react-native#31062 looked at, merged and picked? It fixes a regression issue that prevents Hermes from building on Mac Catalyst.

[kelset]

Hey folks, we did a small patch release to address the Xcode 12.5 issue plus the security fix; so now we can go back to "standard" and discuss 0.64.2 over here -> #224