Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debugger-ui name and reload button #844

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

thymikee
Copy link
Member

Summary:

  • rename module to @react-native-community/cli-debugger-ui
  • fix "Reload app"

Test Plan:

Reload button works

Copy link
Member

@Esemesek Esemesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT

@thymikee thymikee merged commit 0b81877 into master Nov 14, 2019
@thymikee thymikee deleted the chore/fix-debugger branch November 14, 2019 17:21
@slorber
Copy link

slorber commented Dec 10, 2019

Hey,

Like this button.

Wonder if it would be possible to customize this view more and let users add custom buttons?

For example the options in the dev shake menu, or other contextual things like a button to skip current form in DEV?

@thymikee
Copy link
Member Author

Sure. I think we could include some of those by default. But making the UI extensible sounds like terrific idea as well.

We plan to rewrite the debugger UI to React, which will make it possible to compose the whole experience from reusable components. By providing a custom entry-point and exporting some common functionalities (e.g. logging, priority override, connected devices, controls) from the @react-native-community/cli-debugger-ui package, we could empower users to build their own UIs and eventually ship them as defaults if they prove helpful.

However, there's also an ongoing effort from Flipper core team to make it easier to integrate with React Native and write plugins. I think the near future where I'd like to be is making Flipper a go-to development tool that would embed other tools (like React DevTools, Reactotron, perf logging, and many more).

cc @rickhanlonii @axe-fb

@slorber
Copy link

slorber commented Dec 11, 2019

That would be great :)
My current solution is to include a dev toolbar at the top of all my apps with contextual actions (like "fill this form"). But it's a bit annoying to have to use some screen space for that while it could fit in another UI.

@rickhanlonii
Copy link
Collaborator

@slorber for the dev shake menu we added a way to add new options, does this work for you? facebook/react-native#25848

@slorber
Copy link

slorber commented Dec 28, 2019

@rickhanlonii not exactly, I find it particularly annoying to have to take my device from the desk and shake it :) over time it even starts to get risky for the phone. The real pain I have is actually to shake the device, and what we discuss here are actual workarounds for that :)

If there would be a devtools option to toggle the dev menu without shaking, that would remove a part of that pain and is probably more easy to support, as it would be static ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants